Merged
Conversation
Pretty much all other Ueberauth strategies use image: for purposes of the user avatar. I suggest doing this same with the GitHub strategy, so as to avoid needing to customize the templating for this strategy. As an example see: these other strategies LINE 111 in https://github.com/ueberauth/ueberauth_facebook/blob/master/lib/ueberauth/strategy/facebook.ex LINE 109 in https://github.com/fajarmf/ueberauth_linkedin/blob/master/lib/ueberauth/strategy/linkedin.ex LINE 76 https://github.com/ueberauth/ueberauth_twitter/blob/master/lib/ueberauth/strategy/twitter.ex
Member
|
Howdy @willykaram! Back from the dead! Long time no see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty much all other Ueberauth strategies use
image:for purposes of the user's avatar. So I suggest doing the same with the GitHub strategy, so as to avoid needing to customize the templating for this strategy relative to the other in order to display this avatarCurrently, when a developer is trying to display the user's avatar in a template, they need to create a tweak / custom function in order to access the github avatar with
auth.info.urls.avatar_urlinstead of justauth.info.image.As an example of what I mean, see these other strategies:
LINE 111 in https://github.com/ueberauth/ueberauth_facebook/blob/master/lib/ueberauth/strategy/facebook.ex
LINE 109 in https://github.com/fajarmf/ueberauth_linkedin/blob/master/lib/ueberauth/strategy/linkedin.ex
LINE 76 https://github.com/ueberauth/ueberauth_twitter/blob/master/lib/ueberauth/strategy/twitter.ex
I came across this in the course of working on an updated step-by-step guide, screencast and sample app that I'm creating to walk through implementing Ueberauth + Guardian in Phx 1.3.