Skip to content

add Unauthorized status code#4

Merged
k-k merged 1 commit intouecode:masterfrom
L0rD59:UnauthorizedStatusCode
Jun 26, 2014
Merged

add Unauthorized status code#4
k-k merged 1 commit intouecode:masterfrom
L0rD59:UnauthorizedStatusCode

Conversation

@L0rD59
Copy link
Copy Markdown
Contributor

@L0rD59 L0rD59 commented Jun 12, 2014

If the request has no api_key attribute in query, symfony take over and return a response with status code 500 "Internal Server error".

It will be better to return response with 401 status code "Unauthorized" to match to restful design ?

what do you think ?

@cryptiklemur
Copy link
Copy Markdown
Contributor

ping @kmfk, i cant merge

@cordoval
Copy link
Copy Markdown
Contributor

maybe because it is not rebased?

@cryptiklemur
Copy link
Copy Markdown
Contributor

@cordoval i don't have the permissions to merge anymore, theres nothing to rebase

@L0rD59
Copy link
Copy Markdown
Contributor Author

L0rD59 commented Jun 13, 2014

Hi all,

it's rebase for me :

jbrocail@POSTE80 /c/wamp/www/ApiKeyBundle/www (UnauthorizedStatusCode)
$ git remote add upstream https://github.com/uecode/api-key-bundle.git
jbrocail@POSTE80 /c/wamp/www/ApiKeyBundle/www (UnauthorizedStatusCode)
$ git fetch upstream
From https://github.com/uecode/api-key-bundle
 * [new branch]      master     -> upstream/master
jbrocail@POSTE80 /c/wamp/www/ApiKeyBundle/www (UnauthorizedStatusCode)
$ git checkout master
Switched to branch 'master'
jbrocail@POSTE80 /c/wamp/www/ApiKeyBundle/www (master)
$ git merge upstream/master
Already up-to-date.
jbrocail@POSTE80 /c/wamp/www/ApiKeyBundle/www (master)
$ git checkout UnauthorizedStatusCode
Switched to branch 'UnauthorizedStatusCode'
jbrocail@POSTE80 /c/wamp/www/ApiKeyBundle/www (UnauthorizedStatusCode)
$ git rebase master
Current branch UnauthorizedStatusCode is up to date.
jbrocail@POSTE80 /c/wamp/www/ApiKeyBundle/www (UnauthorizedStatusCode)

@cryptiklemur
Copy link
Copy Markdown
Contributor

ping @kmfk again

@cryptiklemur
Copy link
Copy Markdown
Contributor

@kmfk!!!!!!!!

@k-k
Copy link
Copy Markdown
Contributor

k-k commented Jun 26, 2014

sorry for the delay, merging this now

k-k pushed a commit that referenced this pull request Jun 26, 2014
@k-k k-k merged commit 5257a98 into uecode:master Jun 26, 2014
@L0rD59 L0rD59 deleted the UnauthorizedStatusCode branch June 27, 2014 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants