Skip to content

Refactors the config pipeline and fixes improper access to language-specific configuration#50

Closed
ufukty wants to merge 16 commits intomainfrom
feature/unit-tests
Closed

Refactors the config pipeline and fixes improper access to language-specific configuration#50
ufukty wants to merge 16 commits intomainfrom
feature/unit-tests

Conversation

@ufukty
Copy link
Copy Markdown
Owner

@ufukty ufukty commented Apr 24, 2026

This PR is initially intended for the #43, but later it is split into two parts for taking a release with the fixes before initiating the unit testing.

Primarily

Also

ufukty added 2 commits April 27, 2026 20:19
… runtime config representation from the cache (`ConfigManager`).
…. refactors for better seperation of concerns. updates the changelog.

+ fixes the issues with the way `ConfigCompiler` reads the language specific configuration.
+ eliminates the previously used separate transactions with Extensions API which was overriding the language-specific rules with the generic settings manually.
+ refactors the `ConfigCompiler` to first create typed representation of user configuration filed with information acquired through vscode and creating the runtime config representation over it.
@ufukty
Copy link
Copy Markdown
Owner Author

ufukty commented Apr 28, 2026

The last changes on the ConfigCompiler might cause regression. Check the array of language-specific rules doesn't override the language-agnostic rules but are joined to.

ufukty added 3 commits April 28, 2026 13:36
…ng it can't find the particular override of `Error` constructor that accepts second argument used to contain `cause`.
…ng that is used for specifying the language-specific rules.
@ufukty ufukty changed the title Refactors and adds unit tests Refactors the config pipeline and fixes improper access to language-specific configuration May 4, 2026
@ufukty
Copy link
Copy Markdown
Owner Author

ufukty commented May 4, 2026

#53 has some details that this PR didn't address, like centralizing the prompting to prevent getting user attention redundantly.

@ufukty
Copy link
Copy Markdown
Owner Author

ufukty commented May 4, 2026

the PR history got too complicated, it makes more sense to recreate from scratch.

@ufukty ufukty closed this May 4, 2026
@ufukty ufukty deleted the feature/unit-tests branch May 4, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant