feat: tag navigation transitions with addTransitionType#188
Merged
Conversation
Each entry-change transition now calls React's addTransitionType inside startTransition with "navigation" by default. The new experimentalTransitionTypes prop on <Router> accepts a function that returns a custom type list per navigation, receiving the destination URL and underlying navigationType (push/replace/reload/traverse). addTransitionType is currently only available in React Canary, so the implementation looks the API up dynamically and degrades to a no-op on stable React. The prop carries an "experimental" prefix that will be dropped once the React API is stable. Internal adapter subscribe callbacks now pass an EntryChange discriminated union instead of a bare string so the navigationType can flow through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each entry-change transition now calls React's addTransitionType inside
startTransition with "navigation" by default. The new
experimentalTransitionTypes prop on accepts a function that
returns a custom type list per navigation, receiving the destination URL
and underlying navigationType (push/replace/reload/traverse).
addTransitionType is currently only available in React Canary, so the
implementation looks the API up dynamically and degrades to a no-op on
stable React. The prop carries an "experimental" prefix that will be
dropped once the React API is stable.
Internal adapter subscribe callbacks now pass an EntryChange
discriminated union instead of a bare string so the navigationType can
flow through.