fix: normalize file paths in virtual modules for Windows#95
Merged
Conversation
…patibility Use Vite's normalizePath() to convert backslashes to forward slashes in resolved paths before embedding them in generated virtual module code. Closes #93 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalizePath()to convert backslash path separators to forward slashes before embedding resolved paths in generated virtual module codeC:\Users\...are interpreted as escape characters in JavaScript import statementsCloses #93
Test plan
pnpm buildpassespnpm typecheckpassespnpm test:run— 30 unit tests passpnpm test:e2e— 19 e2e tests pass🤖 Generated with Claude Code