fix(docs): Update documentation for Crossorigin and ElementAttribute enums to clarify attribute representation and compliance with MDN standards.#22
Conversation
…te` enums to clarify attribute representation and compliance with MDN standards.
|
Warning Rate limit exceeded@terabytesoftw has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 50 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis change introduces a new ElementAttribute enum documenting standardized HTML element attribute names with MDN references, updates the Crossorigin enum docstring for clarity, and adds a corresponding changelog entry for Bug Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/Values/ElementAttribute.php (1)
20-73: Verify PHP version + header conventions for new enum file
enum ...: stringrequires PHP 8.1+ — please confirm the repo’scomposer.jsonPHP constraint matches.- Also check whether new files in
src/Values/are expected to include the same copyright/license header style asCrossorigin.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
CHANGELOG.mdsrc/Values/Crossorigin.phpsrc/Values/ElementAttribute.php
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-01-09T16:05:15.502Z
Learnt from: terabytesoftw
Repo: ui-awesome/html-attribute PR: 18
File: tests/Support/Provider/Global/ContentEditableProvider.php:32-33
Timestamp: 2026-01-09T16:05:15.502Z
Learning: Preserve the original copyright year in file headers when moving PHP source files between packages within the ui-awesome repositories (e.g., from ui-awesome/html-core to ui-awesome/html-attribute). Do not update the header year to the current year; keep the original creation year as stated in the header. This applies to all PHP files throughout the repo that are moved between packages.
Applied to files:
src/Values/ElementAttribute.phpsrc/Values/Crossorigin.php
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: phpunit / PHP 8.2-ubuntu-latest
- GitHub Check: phpunit / PHP 8.4-ubuntu-latest
- GitHub Check: phpunit / PHP 8.4-windows-2022
- GitHub Check: phpunit / PHP 8.3-windows-2022
- GitHub Check: phpunit / PHP 8.1-windows-2022
- GitHub Check: linter / Super Linter
- GitHub Check: linter / Super Linter
🔇 Additional comments (2)
src/Values/Crossorigin.php (1)
7-18: Docstring clarification looks good (and header year stays intact)The updated summary is more precise about the HTML
crossoriginattribute, with no behavior change. Header year remains consistent.CHANGELOG.md (1)
13-13: No changes needed — the changelog entry is accurate.The use of plural "enums" is correct because the entry refers to both
CrossoriginandElementAttributetogether. This PR updates documentation for existing enums (not adding new ones), which is appropriately classified as a bug fix, consistent with the commit message ("fix(docs)") and the project's changelog conventions.
Pull Request
Summary by CodeRabbit
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.