fix(tests): Remove directory `tests\Stub` and move `tests\Support\Provider` to `tests\Provider` in tests. by terabytesoftw · Pull Request #74 · ui-awesome/html-attribute

terabytesoftw · 2026-02-05T11:52:02Z

Pull Request

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌

…vider` to `tests\Provider` in tests.

coderabbitai · 2026-02-05T11:52:25Z

📝 Walkthrough

Summary by CodeRabbit

Release Notes

New Features
- Extended HTML attribute methods to accept Stringable and UnitEnum types in addition to strings (including accesskey, id, lang, role, charset, download, rel, and more).
Refactor
- Restructured test support directory; moved test data providers to a new namespace location.
- Removed legacy test stub enums in favor of standardized test data providers.

Walkthrough

This PR expands attribute setter method parameter types across multiple trait classes to accept Stringable and UnitEnum in addition to string, relocates test providers from the Support\Provider namespace to a top-level Provider namespace, replaces project-specific test stub enums with shared stubs from PHPForge\Support\Stub, and updates corresponding test data providers and test methods to exercise the broadened type unions.

Changes

Cohort / File(s)	Summary
Attribute Type Expansion `src/Global/HasAccesskey.php`, `src/Global/HasId.php`, `src/Global/HasLang.php`, `src/Global/HasMicroData.php`, `src/Global/HasRole.php`, `src/HasAs.php`, `src/HasCharset.php`, `src/HasDownload.php`, `src/HasHttpEquiv.php`, `src/HasPing.php`, `src/HasReferrerpolicy.php`, `src/HasRel.php`	Widened method parameter types in attribute trait setters from `string\|UnitEnum\|null` to `string\|Stringable\|UnitEnum\|null` (and variants like `bool\|string\|Stringable\|UnitEnum\|null` for HasDownload). Added corresponding imports and updated docblocks.
Test Import Path Updates `tests/Global/CanBeAutofocusTest.php`, `tests/Global/CanBeHiddenTest.php`, `tests/Global/HasTest.php`, `tests/HasTest.php`	Updated provider import paths from `Tests\Support\Provider\` to `Tests\Provider\`. Multiple test class method signatures expanded to match widened parameter types accepting `Stringable` and `UnitEnum`.
Test Provider Namespace Relocation `tests/Provider/`, `tests/Provider/Global/`	Relocated all test provider classes from `UIAwesome\Html\Attribute\Tests\Support\Provider` to `UIAwesome\Html\Attribute\Tests\Provider` (removed Support segment). Expanded PHPDoc return types in values() methods to include `Stringable` in type unions.
Test Provider Data Expansion `tests/Provider/AsProvider.php`, `tests/Provider/CharsetProvider.php`, `tests/Provider/Global/AccesskeyProvider.php`, `tests/Provider/Global/IdProvider.php`, `tests/Provider/Global/ItemIdProvider.php`, `tests/Provider/Global/ItemPropProvider.php`, `tests/Provider/Global/ItemTypeProvider.php`, `tests/Provider/Global/LangProvider.php`, `tests/Provider/Global/RoleProvider.php`, `tests/Provider/*/...`	Added new test cases for `Stringable` instances and enum-backed values (`BackedString::VALUE`, `Unit::value`). Introduced anonymous Stringable implementations and expanded test data sets to cover broader type unions.
Stub Enum Replacements `tests/Provider/Global/AriaProvider.php`, `tests/Provider/Global/ClassProvider.php`, `tests/Provider/Global/DataProvider.php`, `tests/Provider/Global/EventProvider.php`, `tests/Provider/Global/NonceProvider.php`, `tests/Provider/Global/StyleProvider.php`, `tests/Provider/Global/TitleProvider.php`	Replaced local stub enums (AlertType, ButtonSize, Priority, Status) with imports from `PHPForge\Support\Stub` (BackedString, BackedInteger, Unit). Updated test data to use new enum sources and adjusted expected values accordingly.
Removed Test Stubs `tests/Support/Stub/Values/AlertType.php`, `tests/Support/Stub/Values/Backed.php`, `tests/Support/Stub/Values/ButtonSize.php`, `tests/Support/Stub/Values/Priority.php`, `tests/Support/Stub/Values/Status.php`, `tests/Support/Stub/Values/Unit.php`	Deleted project-specific test stub enum files, consolidating on external PHPForge stubs.
Metadata Updates `CHANGELOG.md`	Added changelog entry noting the relocation of test provider scaffolding as part of Bug `#74`.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

fix(attribute): Enhance HTML attribute element handling with Stringable and UnitEnum support. #66: Both PRs modify attribute setter APIs to widen parameter types across multiple trait signatures, adding Stringable and UnitEnum support to the same method definitions.
feat(tests): Add php-forge/support as a development dependency and update related test classes. #27: Both PRs update test provider namespaces and replace local test stubs with shared PHPForge\Support types, including composer dependency and import reorganization.
fix(docs): Update documentation for HTML attribute elements in Element namespace. #72: Both PRs relocate test provider namespace structures, updating import paths from Support\Provider to Provider across test infrastructure.

Poem

🐰 Hop, hop, the types grow wide,
Stringable joins the ride,
Providers leap from Support's nest,
To Provider's cleaner test!
Stubs retire, new imports bloom,
Wider validation fills the room. 🌸

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing tests\Stub directory and moving tests\Support\Provider to tests\Provider. It is concise, specific, and clearly summarizes the primary structural refactoring in the changeset.
Description check	✅ Passed	The description is related to the changeset, confirming it is a bugfix with no breaking changes. While minimal, it provides relevant context about the nature and scope of the changes.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix_mini_23

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

tests/Provider/BlockingProvider.php (1)

16-16: ⚠️ Potential issue | 🟡 Minor

Verify the copyright year wasn’t updated during the move.
If this file was moved from tests/Support/Provider, keep the original creation year in the header rather than updating it to 2026.

Based on learnings: Preserve the original copyright year in file headers when moving PHP source files between packages within the ui-awesome repositories.

🤖 Fix all issues with AI agents

In `@tests/Provider/ValueProvider.php`:
- Around line 5-9: The tests import PHPForge\Support\Stub\BackedString and Unit
but the composer.json lacks the phpforge/support package; update composer.json
to add "phpforge/support" (preferably under require-dev) so BackedString and
Unit are available, or verify the package is provided by the workspace/parent
and document that; ensure composer.lock is updated and run composer install so
the ValueProvider.php imports resolve at test time.

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0aa3cc4 and 7c6da76.

📒 Files selected for processing (105)

CHANGELOG.md
src/Global/HasAccesskey.php
src/Global/HasId.php
src/Global/HasLang.php
src/Global/HasMicroData.php
src/Global/HasRole.php
src/HasAs.php
src/HasCharset.php
src/HasDownload.php
src/HasHttpEquiv.php
src/HasPing.php
src/HasReferrerpolicy.php
src/HasRel.php
tests/Global/CanBeAutofocusTest.php
tests/Global/CanBeHiddenTest.php
tests/Global/HasAccesskeyTest.php
tests/Global/HasAriaTest.php
tests/Global/HasClassTest.php
tests/Global/HasContentEditableTest.php
tests/Global/HasDataTest.php
tests/Global/HasDirTest.php
tests/Global/HasDraggableTest.php
tests/Global/HasEventsTest.php
tests/Global/HasIdTest.php
tests/Global/HasLangTest.php
tests/Global/HasMicroDataTest.php
tests/Global/HasNonceTest.php
tests/Global/HasRoleTest.php
tests/Global/HasSpellcheckTest.php
tests/Global/HasStyleTest.php
tests/Global/HasTabIndexTest.php
tests/Global/HasTitleTest.php
tests/Global/HasTranslateTest.php
tests/HasAsTest.php
tests/HasBlockingTest.php
tests/HasCharsetTest.php
tests/HasContentTest.php
tests/HasCrossoriginTest.php
tests/HasDownloadTest.php
tests/HasFetchpriorityTest.php
tests/HasHreflangTest.php
tests/HasHttpEquivTest.php
tests/HasImagesizesTest.php
tests/HasImagesrcsetTest.php
tests/HasIntegrityTest.php
tests/HasMediaTest.php
tests/HasPingTest.php
tests/HasReferrerpolicyTest.php
tests/HasRelTest.php
tests/HasSizesTest.php
tests/HasSrcTest.php
tests/HasTargetTest.php
tests/HasTypeTest.php
tests/HasValueTest.php
tests/Provider/AsProvider.php
tests/Provider/BlockingProvider.php
tests/Provider/CharsetProvider.php
tests/Provider/ContentProvider.php
tests/Provider/CrossoriginProvider.php
tests/Provider/DownloadProvider.php
tests/Provider/FetchpriorityProvider.php
tests/Provider/Global/AccesskeyProvider.php
tests/Provider/Global/AriaProvider.php
tests/Provider/Global/AutofocusProvider.php
tests/Provider/Global/ClassProvider.php
tests/Provider/Global/ContentEditableProvider.php
tests/Provider/Global/DataProvider.php
tests/Provider/Global/DirProvider.php
tests/Provider/Global/DraggableProvider.php
tests/Provider/Global/EventProvider.php
tests/Provider/Global/HiddenProvider.php
tests/Provider/Global/IdProvider.php
tests/Provider/Global/ItemIdProvider.php
tests/Provider/Global/ItemPropProvider.php
tests/Provider/Global/ItemRefProvider.php
tests/Provider/Global/ItemScopeProvider.php
tests/Provider/Global/ItemTypeProvider.php
tests/Provider/Global/LangProvider.php
tests/Provider/Global/NonceProvider.php
tests/Provider/Global/RoleProvider.php
tests/Provider/Global/SpellcheckProvider.php
tests/Provider/Global/StyleProvider.php
tests/Provider/Global/TabIndexProvider.php
tests/Provider/Global/TitleProvider.php
tests/Provider/Global/TranslateProvider.php
tests/Provider/HreflangProvider.php
tests/Provider/HttpEquivProvider.php
tests/Provider/ImagesizesProvider.php
tests/Provider/ImagesrcsetProvider.php
tests/Provider/IntegrityProvider.php
tests/Provider/MediaProvider.php
tests/Provider/PingProvider.php
tests/Provider/ReferrerpolicyProvider.php
tests/Provider/RelProvider.php
tests/Provider/SizesProvider.php
tests/Provider/SrcProvider.php
tests/Provider/TargetProvider.php
tests/Provider/TypeProvider.php
tests/Provider/ValueProvider.php
tests/Support/Stub/Values/AlertType.php
tests/Support/Stub/Values/Backed.php
tests/Support/Stub/Values/ButtonSize.php
tests/Support/Stub/Values/Priority.php
tests/Support/Stub/Values/Status.php
tests/Support/Stub/Values/Unit.php

💤 Files with no reviewable changes (6)

tests/Support/Stub/Values/ButtonSize.php
tests/Support/Stub/Values/Status.php
tests/Support/Stub/Values/Backed.php
tests/Support/Stub/Values/Unit.php
tests/Support/Stub/Values/Priority.php
tests/Support/Stub/Values/AlertType.php

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2026-01-09T16:05:15.502Z

Learnt from: terabytesoftw
Repo: ui-awesome/html-attribute PR: 18
File: tests/Support/Provider/Global/ContentEditableProvider.php:32-33
Timestamp: 2026-01-09T16:05:15.502Z
Learning: Preserve the original copyright year in file headers when moving PHP source files between packages within the ui-awesome repositories (e.g., from ui-awesome/html-core to ui-awesome/html-attribute). Do not update the header year to the current year; keep the original creation year as stated in the header. This applies to all PHP files throughout the repo that are moved between packages.

Applied to files:

tests/Global/HasClassTest.php
tests/Global/HasTabIndexTest.php
tests/Provider/Global/AutofocusProvider.php
src/HasDownload.php
src/Global/HasLang.php
src/HasCharset.php
src/HasAs.php
tests/Global/HasDirTest.php
tests/Global/HasNonceTest.php
tests/Provider/Global/ContentEditableProvider.php
tests/Provider/FetchpriorityProvider.php
src/Global/HasRole.php
tests/HasSizesTest.php
src/HasPing.php
tests/HasContentTest.php
tests/Global/HasAccesskeyTest.php
src/HasHttpEquiv.php
tests/Global/HasDraggableTest.php
tests/HasTypeTest.php
tests/HasFetchpriorityTest.php
tests/Provider/Global/HiddenProvider.php
src/Global/HasMicroData.php
src/HasReferrerpolicy.php
tests/HasAsTest.php
tests/HasReferrerpolicyTest.php
tests/Global/HasContentEditableTest.php
tests/HasMediaTest.php
tests/HasDownloadTest.php
tests/Global/HasAriaTest.php
tests/HasRelTest.php
tests/Global/CanBeAutofocusTest.php
tests/HasIntegrityTest.php
tests/HasHreflangTest.php
tests/Provider/IntegrityProvider.php
tests/Provider/Global/TitleProvider.php
tests/Provider/Global/DirProvider.php
tests/Provider/ValueProvider.php
tests/Provider/TypeProvider.php
tests/Provider/Global/DataProvider.php
tests/Provider/Global/NonceProvider.php
tests/HasCrossoriginTest.php
tests/Global/HasSpellcheckTest.php
tests/Global/HasStyleTest.php
tests/Provider/CharsetProvider.php
tests/Global/HasRoleTest.php
tests/Global/HasTranslateTest.php
tests/Global/HasTitleTest.php
tests/Provider/Global/ItemIdProvider.php
src/Global/HasId.php
tests/Provider/Global/TranslateProvider.php
tests/Provider/RelProvider.php
tests/Provider/Global/ItemScopeProvider.php
tests/Provider/CrossoriginProvider.php
tests/Provider/ImagesizesProvider.php
tests/Global/HasDataTest.php
tests/Global/HasLangTest.php
tests/HasPingTest.php
tests/Provider/ContentProvider.php
tests/Provider/Global/LangProvider.php
tests/Provider/Global/ClassProvider.php
tests/HasImagesrcsetTest.php
tests/HasValueTest.php
src/Global/HasAccesskey.php
tests/Provider/SrcProvider.php
tests/Global/CanBeHiddenTest.php
tests/Provider/BlockingProvider.php
tests/HasTargetTest.php
tests/Provider/SizesProvider.php
tests/Provider/PingProvider.php
tests/Provider/TargetProvider.php
tests/Provider/Global/ItemTypeProvider.php
tests/HasHttpEquivTest.php
tests/Provider/ReferrerpolicyProvider.php
tests/HasImagesizesTest.php
tests/Provider/HreflangProvider.php
tests/Global/HasEventsTest.php
tests/HasSrcTest.php
tests/Provider/Global/AccesskeyProvider.php
tests/Provider/AsProvider.php
tests/Global/HasIdTest.php
tests/Provider/Global/StyleProvider.php
tests/Provider/Global/TabIndexProvider.php
tests/Provider/Global/IdProvider.php
tests/Provider/DownloadProvider.php
src/HasRel.php
tests/HasCharsetTest.php
tests/Provider/Global/RoleProvider.php
tests/Provider/ImagesrcsetProvider.php
tests/HasBlockingTest.php
tests/Provider/Global/AriaProvider.php
tests/Provider/Global/SpellcheckProvider.php
tests/Provider/Global/EventProvider.php
tests/Provider/Global/ItemRefProvider.php
tests/Provider/Global/DraggableProvider.php
tests/Provider/MediaProvider.php
tests/Global/HasMicroDataTest.php
tests/Provider/Global/ItemPropProvider.php
tests/Provider/HttpEquivProvider.php

🧬 Code graph analysis (55)

tests/Global/HasClassTest.php (1)

tests/Provider/Global/ClassProvider.php (1)

ClassProvider (19-114)

tests/Global/HasTabIndexTest.php (1)

tests/Provider/Global/TabIndexProvider.php (1)

TabIndexProvider (15-109)

src/HasDownload.php (1)

src/HasValue.php (1)

value (43-46)

src/Global/HasLang.php (1)

src/HasValue.php (1)

value (43-46)

src/HasCharset.php (1)

src/HasValue.php (1)

value (43-46)

src/HasAs.php (1)

src/HasValue.php (1)

value (43-46)

tests/Global/HasNonceTest.php (1)

tests/Provider/Global/NonceProvider.php (1)

NonceProvider (19-95)

src/Global/HasRole.php (1)

src/HasValue.php (1)

value (43-46)

tests/HasSizesTest.php (1)

tests/Provider/SizesProvider.php (1)

SizesProvider (19-102)

src/HasPing.php (1)

src/HasValue.php (1)

value (43-46)

tests/HasContentTest.php (1)

tests/Provider/ContentProvider.php (1)

ContentProvider (19-102)

tests/Global/HasAccesskeyTest.php (2)

tests/Provider/Global/AccesskeyProvider.php (1)

AccesskeyProvider (19-95)

src/Global/HasAccesskey.php (1)

accesskey (37-40)

src/HasHttpEquiv.php (1)

src/HasValue.php (1)

value (43-46)

tests/Global/HasDraggableTest.php (1)

tests/Provider/Global/DraggableProvider.php (1)

DraggableProvider (19-89)

tests/HasTypeTest.php (1)

tests/Provider/TypeProvider.php (1)

TypeProvider (20-86)

tests/HasFetchpriorityTest.php (1)

tests/Provider/FetchpriorityProvider.php (1)

FetchpriorityProvider (19-68)

src/Global/HasMicroData.php (1)

src/HasValue.php (1)

value (43-46)

src/HasReferrerpolicy.php (2)

src/Element/HasReferrerpolicy.php (1)

referrerpolicy (47-52)

src/HasValue.php (1)

value (43-46)

tests/HasAsTest.php (2)

tests/Provider/AsProvider.php (1)

AsProvider (20-86)

src/HasAs.php (1)

as (46-51)

tests/HasReferrerpolicyTest.php (1)

src/HasReferrerpolicy.php (1)

referrerpolicy (46-51)

tests/Global/HasContentEditableTest.php (1)

tests/Provider/Global/ContentEditableProvider.php (1)

ContentEditableProvider (19-89)

tests/HasMediaTest.php (1)

tests/Provider/MediaProvider.php (1)

MediaProvider (19-95)

tests/Global/HasAriaTest.php (1)

tests/Provider/Global/AriaProvider.php (1)

AriaProvider (20-494)

tests/HasRelTest.php (2)

tests/Provider/RelProvider.php (1)

RelProvider (20-86)

src/HasRel.php (1)

rel (46-51)

tests/Global/CanBeAutofocusTest.php (1)

tests/Provider/Global/AutofocusProvider.php (1)

AutofocusProvider (15-53)

tests/HasIntegrityTest.php (2)

tests/Provider/IntegrityProvider.php (1)

IntegrityProvider (19-95)

src/HasIntegrity.php (1)

integrity (40-43)

tests/HasCrossoriginTest.php (1)

tests/Provider/CrossoriginProvider.php (1)

CrossoriginProvider (19-68)

tests/Global/HasSpellcheckTest.php (1)

tests/Provider/Global/SpellcheckProvider.php (1)

SpellcheckProvider (15-81)

tests/Global/HasStyleTest.php (1)

tests/Provider/Global/StyleProvider.php (1)

StyleProvider (19-102)

tests/Provider/CharsetProvider.php (1)

src/Global/HasClass.php (1)

class (50-61)

tests/Global/HasRoleTest.php (2)

tests/Provider/Global/RoleProvider.php (1)

RoleProvider (20-86)

src/Global/HasRole.php (1)

role (44-49)

tests/Global/HasTranslateTest.php (1)

tests/Provider/Global/TranslateProvider.php (1)

TranslateProvider (19-89)

tests/Global/HasTitleTest.php (1)

tests/Provider/Global/TitleProvider.php (1)

TitleProvider (19-95)

src/Global/HasId.php (1)

src/HasValue.php (1)

value (43-46)

tests/Provider/RelProvider.php (1)

src/Global/HasClass.php (1)

class (50-61)

tests/Global/HasLangTest.php (2)

tests/Provider/Global/LangProvider.php (1)

LangProvider (20-86)

src/Global/HasLang.php (1)

lang (44-49)

tests/HasPingTest.php (2)

tests/Provider/PingProvider.php (1)

PingProvider (19-102)

src/HasPing.php (1)

ping (40-43)

tests/Provider/Global/LangProvider.php (1)

src/Global/HasClass.php (1)

class (50-61)

tests/HasImagesrcsetTest.php (1)

tests/Provider/ImagesrcsetProvider.php (1)

ImagesrcsetProvider (19-102)

tests/HasValueTest.php (2)

tests/Provider/ValueProvider.php (1)

ValueProvider (19-116)

src/HasValue.php (1)

value (43-46)

src/Global/HasAccesskey.php (1)

src/HasValue.php (1)

value (43-46)

tests/Global/CanBeHiddenTest.php (1)

tests/Provider/Global/HiddenProvider.php (1)

HiddenProvider (15-53)

tests/HasTargetTest.php (1)

tests/Provider/TargetProvider.php (1)

TargetProvider (19-68)

tests/HasHttpEquivTest.php (2)

tests/Provider/HttpEquivProvider.php (1)

HttpEquivProvider (20-86)

src/HasHttpEquiv.php (1)

httpEquiv (46-51)

tests/Provider/ReferrerpolicyProvider.php (1)

src/Global/HasClass.php (1)

class (50-61)

tests/HasImagesizesTest.php (1)

tests/Provider/ImagesizesProvider.php (1)

ImagesizesProvider (19-102)

tests/Global/HasEventsTest.php (1)

tests/Provider/Global/EventProvider.php (1)

EventProvider (20-376)

tests/HasSrcTest.php (1)

src/HasSrc.php (1)

src (40-43)

tests/Provider/AsProvider.php (1)

src/Global/HasClass.php (1)

class (50-61)

tests/Global/HasIdTest.php (2)

tests/Provider/Global/IdProvider.php (1)

IdProvider (19-95)

src/Global/HasId.php (1)

id (37-40)

src/HasRel.php (1)

src/HasValue.php (1)

value (43-46)

tests/HasCharsetTest.php (2)

tests/Provider/CharsetProvider.php (1)

CharsetProvider (20-86)

src/HasCharset.php (1)

charset (46-51)

tests/Provider/Global/RoleProvider.php (1)

src/Global/HasClass.php (1)

class (50-61)

tests/Global/HasMicroDataTest.php (1)

src/Global/HasMicroData.php (4)

itemId (37-40)

itemProp (57-60)

itemRef (77-80)

itemType (117-120)

tests/Provider/HttpEquivProvider.php (1)

src/Global/HasClass.php (1)

class (50-61)

🪛 PHPMD (2.15.0)

src/HasAs.php

[warning] 46-51: Avoid using short method names like HasAs::as(). The configured minimum method name length is 3. (undefined)

(ShortMethodName)

tests/HasAsTest.php

[warning] 70-70: Avoid variables with short names like $as. Configured minimum length is 3. (undefined)

(ShortVariable)

tests/Provider/CharsetProvider.php