fix(form): Update parameter descriptions to clarify usage for form attributes and input elements.

[terabytesoftw]

Pull Request

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Changelog

  • Added a Bug #30 entry noting updated form attribute parameter descriptions.

• Documentation

  • Clarified form attribute parameter descriptions to explicitly note that passing null removes the attribute.
  • Updated input element class descriptions to state they "render" the corresponding HTML elements.

• Tests

  • Updated test group metadata for improved test organization and categorization.

Walkthrough

Documentation and test metadata updates: PHPDoc parameter descriptions for several form attribute traits clarified to note null removes attributes; many input class docblocks changed wording from "Represents" to "Renders"; PHPUnit group annotations reassigned; CHANGELOG entry added for Bug #30.

Changes

Cohort / File(s)	Summary
Form Attribute Traits src/Form/Attribute/HasFormaction.php, src/Form/Attribute/HasFormenctype.php, src/Form/Attribute/HasFormmethod.php, src/Form/Attribute/HasFormnovalidate.php, src/Form/Attribute/HasFormtarget.php	Updated PHPDoc parameter descriptions to clarify that passing null removes the corresponding form attribute.
Form Input Element Classes src/Form/InputPassword.php, src/Form/InputRange.php, src/Form/InputReset.php, src/Form/InputSearch.php, src/Form/InputSubmit.php, src/Form/InputTel.php, src/Form/InputText.php, src/Form/InputTime.php, src/Form/InputUrl.php, src/Form/InputWeek.php	Class docblocks reworded from "Represents the HTML <input type=\"...\"> element" to "Renders the HTML <input type=\"...\"> element" (documentation-only changes).
Test File Group Annotations tests/Phrasing/ITest.php, tests/Phrasing/SpanTest.php, tests/Root/FooterTest.php	PHPUnit Group attributes and test namespace for FooterTest adjusted to reassign tests (e.g., flow → phrasing or root).
Changelog CHANGELOG.md	Added Bug #30 entry documenting the updated parameter description clarifications.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• fix(tests): Standardize PHPDoc headers in tests directory. #21: Similar changes to PHPDoc and test header comments affecting the same test files and documentation patterns.
• feat(form): Add InputReset class for HTML <input type="reset"> element with attributes and rendering capabilities. #28: Adds/edits the InputReset class that this PR updates the docblock for.
• feat(form); Add InputSubmit class for HTML <input type="submit"> element with attributes and rendering capabilities. #26: Touches InputSubmit-related files and related PHPDoc wording adjusted here.

Poem

🐰 I hopped through docblocks with nimble feet,
I nudged “Represents” to “Renders” — neat.
Null whispers softly, attributes fall away,
Tests found new burrows where they now play.
A tiny changelog carrot — Bug thirty hooray!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main changes: updating parameter descriptions for form attributes and input elements to clarify usage.
Description check	✅ Passed	The description relates to the changeset by identifying it as a bugfix that does not break backward compatibility, which aligns with the documentation updates and test corrections in the PR.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix_mini_4

---

No actionable comments were generated in the recent review. 🎉

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5936c19 and 4afbb6b.

📒 Files selected for processing (1)

• tests/Root/FooterTest.php

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2026-02-06T21:37:44.509Z

Learnt from: terabytesoftw
Repo: ui-awesome/html PR: 24
File: tests/Form/InputTextTest.php:33-620
Timestamp: 2026-02-06T21:37:44.509Z
Learning: In the ui-awesome/html repository, prefer individual test methods over PHPUnit data providers in test classes. This helps maintainers see exactly how each test behaves without cross-referencing data providers. Apply to all PHP test files under tests. Use separate, descriptively named test methods to cover different inputs/edge cases; retain data providers only if they clearly improve readability or reduce duplication.

Applied to files:

• tests/Root/FooterTest.php

🧬 Code graph analysis (1)

tests/Root/FooterTest.php (3)

src/Root/Html.php (1)

• Html (27-40)

tests/Phrasing/ITest.php (1)

• Group (35-547)

tests/Flow/HrTest.php (1)

• Group (35-441)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)

• GitHub Check: linter / Super Linter
• GitHub Check: mutation / PHP 8.5-ubuntu-latest
• GitHub Check: phpunit / PHP 8.4-ubuntu-latest
• GitHub Check: phpunit / PHP 8.1-windows-2022
• GitHub Check: phpunit / PHP 8.2-windows-2022
• GitHub Check: phpunit / PHP 8.4-windows-2022
• GitHub Check: phpunit / PHP 8.3-windows-2022
• GitHub Check: phpunit / PHP 8.5-windows-2022
• GitHub Check: phpunit / PHP 8.5-ubuntu-latest
• GitHub Check: linter / Super Linter

🔇 Additional comments (1)

tests/Root/FooterTest.php (1)

5-5: Namespace and group alignment with directory structure looks correct.

The namespace UIAwesome\Html\Tests\Root now matches the file path tests/Root/FooterTest.php and the source class location UIAwesome\Html\Root\Footer. The PHPUnit group change from 'flow' to 'root' is consistent with this reclassification.

Also applies to: 38-38

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4af7f9d) to head (4afbb6b).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff             @@
##                main       #32   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        98        98           
===========================================
  Files             65        65           
  Lines            203       203           
===========================================
  Hits             203       203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

tests/Root/FooterTest.php (1)

5-5: ⚠️ Potential issue | 🟡 Minor

Update namespace to match directory structure.

The file resides in tests/Root/FooterTest.php but uses namespace UIAwesome\Html\Tests\Flow. All other test files in the same directory (BodyTest.php, HeadTest.php, HeaderTest.php, HtmlTest.php) use UIAwesome\Html\Tests\Root. Update the namespace to UIAwesome\Html\Tests\Root for consistency.

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4af7f9d and 5936c19.

📒 Files selected for processing (19)

• CHANGELOG.md
• src/Form/Attribute/HasFormaction.php
• src/Form/Attribute/HasFormenctype.php
• src/Form/Attribute/HasFormmethod.php
• src/Form/Attribute/HasFormnovalidate.php
• src/Form/Attribute/HasFormtarget.php
• src/Form/InputPassword.php
• src/Form/InputRange.php
• src/Form/InputReset.php
• src/Form/InputSearch.php
• src/Form/InputSubmit.php
• src/Form/InputTel.php
• src/Form/InputText.php
• src/Form/InputTime.php
• src/Form/InputUrl.php
• src/Form/InputWeek.php
• tests/Phrasing/ITest.php
• tests/Phrasing/SpanTest.php
• tests/Root/FooterTest.php

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2026-02-06T21:37:44.509Z

Learnt from: terabytesoftw
Repo: ui-awesome/html PR: 24
File: tests/Form/InputTextTest.php:33-620
Timestamp: 2026-02-06T21:37:44.509Z
Learning: In the ui-awesome/html repository, prefer individual test methods over PHPUnit data providers in test classes. This helps maintainers see exactly how each test behaves without cross-referencing data providers. Apply to all PHP test files under tests. Use separate, descriptively named test methods to cover different inputs/edge cases; retain data providers only if they clearly improve readability or reduce duplication.

Applied to files:

• tests/Phrasing/SpanTest.php
• tests/Root/FooterTest.php
• tests/Phrasing/ITest.php

🧬 Code graph analysis (3)

tests/Phrasing/SpanTest.php (2)

tests/Phrasing/ITest.php (1)

• Group (35-547)

tests/Flow/HrTest.php (1)

• Group (35-441)

tests/Root/FooterTest.php (1)

tests/Flow/HrTest.php (1)

• Group (35-441)

tests/Phrasing/ITest.php (4)

tests/Phrasing/SpanTest.php (1)

• Group (35-547)

tests/Flow/HrTest.php (1)

• Group (35-441)

tests/Flow/MainTest.php (1)

• Group (37-703)

tests/Flow/PTest.php (1)

• Group (37-703)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

• GitHub Check: phpstan / PHP 8.5-ubuntu-latest
• GitHub Check: phpunit / PHP 8.2-ubuntu-latest
• GitHub Check: mutation / PHP 8.5-ubuntu-latest
• GitHub Check: phpunit / PHP 8.3-windows-2022
• GitHub Check: phpunit / PHP 8.4-ubuntu-latest
• GitHub Check: phpunit / PHP 8.5-ubuntu-latest
• GitHub Check: phpunit / PHP 8.1-windows-2022
• GitHub Check: phpunit / PHP 8.2-windows-2022
• GitHub Check: phpunit / PHP 8.1-ubuntu-latest
• GitHub Check: linter / Super Linter
• GitHub Check: linter / Super Linter

🔇 Additional comments (19)

tests/Phrasing/ITest.php (1)

35-36: Group annotation correctly aligned with namespace.

The #[Group('phrasing')] annotation now matches the Tests\Phrasing namespace, consistent with the convention seen in tests/Flow/*Test.php using Group('flow').

CHANGELOG.md (1)

19-19: LGTM!

Changelog entry follows the established format and accurately describes the scope of this PR.

src/Form/InputTime.php (1)

24-24: Docblock wording update looks good.

Consistent with the "Renders the HTML …" phrasing adopted across all input element classes in this PR.

src/Form/InputSearch.php (1)

27-27: LGTM!

Consistent docblock update matching the rest of the input element classes.

tests/Phrasing/SpanTest.php (1)

35-36: Group annotation correctly aligned with namespace.

Consistent with the same change in ITest.php — both phrasing-element test classes now use Group('phrasing').

src/Form/InputTel.php (1)

26-26: LGTM!

Consistent docblock update.

src/Form/InputWeek.php (1)

24-24: LGTM!

Consistent docblock update.

src/Form/InputReset.php (1)

14-14: LGTM!

Docblock wording update is consistent with the broader PR pattern.

src/Form/InputText.php (1)

27-27: LGTM!

src/Form/InputSubmit.php (1)

22-22: LGTM!

src/Form/InputUrl.php (1)

26-26: LGTM!

src/Form/InputRange.php (1)

22-22: LGTM!

tests/Root/FooterTest.php (1)

37-38: Group annotation correction looks good.

Changing from Group('flow') to Group('root') correctly reflects that Footer is a root element.

src/Form/InputPassword.php (1)

25-25: LGTM!

src/Form/Attribute/HasFormmethod.php (1)

31-31: LGTM!

The updated @param description accurately documents the existing null behavior consistent with the method signature.

src/Form/Attribute/HasFormnovalidate.php (1)

28-28: LGTM!

Clear and consistent with the other form-attribute doc updates.

src/Form/Attribute/HasFormenctype.php (1)

31-32: LGTM!

Documentation accurately reflects the nullable parameter behavior.

src/Form/Attribute/HasFormtarget.php (1)

31-32: LGTM!

Consistent with the parallel doc updates across the other form-attribute traits.

src/Form/Attribute/HasFormaction.php (1)

31-31: LGTM!

Accurately documents the null removal semantics matching the existing method signature.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}