Skip to content

Conversation

@felixmosh
Copy link
Contributor

Bundlers such as Webpack are not support jsnext:main entry, but do support module.

I've just added that entry, I've checked on my build, and webpack was able to enable module concat optimisation and tree shaking.

@felixmosh felixmosh closed this Jul 15, 2018
@felixmosh felixmosh reopened this Jul 15, 2018
@felixmosh
Copy link
Contributor Author

felixmosh commented Jul 15, 2018

someone can assist, how the build fails on webpack configuration? :
It passes locally
image

@christopherthielen
Copy link
Member

When we run tests on travis, we run unit tests AND downstream integration tests (npm run test:downstream). Don't worry about fixing those, I'll check on them. Thanks for the PR!

Note: I do recall there was a reason I used jsnext:main over module and I think it had something to do with Angular AoT compilation. However, Angular has had a few major release since then, and we've done some other workaround to hint to Angular how to consume the library. If the downstream tests pass, then I'm fairly confident this change won't affect Angular consumers.

@christopherthielen christopherthielen merged commit 2103b14 into ui-router:master Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants