Conversation
1 task
Contributor
|
Remaining work here is to make the focus styles stronger and get review from @pyrello. |
Contributor
I'm going to review this today. |
Contributor
|
Some initial thoughts:
|
Contributor
|
@GaryRidgway and I discussed my comments above. Based on that conversation, here is my understanding of next steps:
<form>
<slot></slot>
</form>
|
…-factored to update stories files to use current best practice.
…nt in this section and reviewing all the changes would greatly expand the scope of this PR.
pyrello
approved these changes
Jul 30, 2025
Contributor
pyrello
left a comment
There was a problem hiding this comment.
This looks good and provides a good starting point for adding form styles as well as a nice looking example form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a branch here that I am using as a sort of checklist to go through and move styles over.