Conversation
Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
- Coverage 19.03% 18.85% -0.18%
==========================================
Files 312 315 +3
Lines 28845 29160 +315
Branches 1322 1325 +3
==========================================
+ Hits 5490 5499 +9
- Misses 23355 23661 +306 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| placeholder={t("aiPrompt_prompt_placeholder")} | ||
| className="resize-none max-h-80" | ||
| onInput={(e) => { | ||
| updateHeight(e.target as HTMLTextAreaElement) |
There was a problem hiding this comment.
ShadcnのTextareaはそのままでも自動で高さが変わるはずです。updateHeight が本当に必要か、確認してください。
There was a problem hiding this comment.
確認しました。このプロジェクトの ShadCN Textarea は標準の <textarea> ラッパーで自動リサイズ機能は持っていませんが、rows={5} で初期サイズを確保しており updateHeight ロジックは冗長です。updateHeight・useEffect・useRef を削除し、コンポーネントをシンプルにしました(328d217)。
| ? t("iconUrl_desc") | ||
| : openMode === OPEN_MODE.PAGE_ACTION | ||
| : openMode === OPEN_MODE.PAGE_ACTION || | ||
| openMode === OPEN_MODE.AI_PROMPT |
There was a problem hiding this comment.
AI_PROMPTには開始URLがないため、説明と実態が乖離しています。ここでは「メニューのアイコンとして表示されます」としてください。他の言語には適切に翻訳してください、
There was a problem hiding this comment.
新しい i18n キー Option_iconUrl_desc_aiPrompt(「メニューのアイコンとして表示されます。」)を全14ロケールに追加し、CommandEditDialog.tsx で AI_PROMPT モード時にこのキーを使用するよう変更しました(328d217)。
| export const AiPromptOptionSchema = z.object({ | ||
| serviceId: z.string().min(1), | ||
| prompt: z.string(), | ||
| openMode: z.nativeEnum(PAGE_ACTION_OPEN_MODE), |
There was a problem hiding this comment.
AI_Prompt モードではSidePanelで使用することも許容したい。
SEARCH_OPEN_MODE を使用してください。
There was a problem hiding this comment.
対応しました(328d217)。
AiPromptOptionSchema.openModeをz.enum(SEARCH_OPEN_MODE)に変更してSidePanel を許容AiPromptOption型のopenModeをPAGE_ACTION_OPEN_MODE→OPEN_MODEに変更AiPromptSection.tsxのOpenModeToggleFieldをtype="search"に変更(SidePanel選択肢を表示)- action handler で
OPEN_MODE.SIDE_PANELを個別処理(BgCommand.openSidePanelで AI サービス URL を開く)
|
@copilot |
…DE, add aiPrompt icon description Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
… correctly Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
原因を特定しました(10eabf0)。 原因: 修正: Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
AI_PROMPT = "aiPrompt"toOPEN_MODEenum inpackages/shared/src/constants/open-mode.tspackages/extension/src/services/aiPrompt.tsCOMMAND_TYPE.AI_PROMPT, mappings, metadata, and groups topackages/extension/src/const.tsAiPromptOptionandAiPromptCommandtypes topackages/extension/src/types/index.tsaiPromptSchema(usesSEARCH_OPEN_MODE, SidePanel対応) andisAiPromptTypetopackages/extension/src/types/schema.tspackages/extension/src/action/aiPrompt.tswithSIDE_PANELmode supportpackages/extension/src/action/index.tspackages/extension/src/components/option/editor/AiPromptSection.tsx(removed unnecessaryupdateHeight/useEffect/useRef)CommandEditDialog.tsxto add AI prompt section,getDefaultcase, andiconUrl_desc_aiPromptdescriptionBotMessageSquareicon toCommandType.tsxIconMapOption_iconUrl_desc_aiPrompt)insertTextinInputPopup.tsxto use native prototype setter (Object.getOwnPropertyDescriptor(proto, 'value').set) so React's syntheticonChangefires correctly for controlled inputs (React Hook Form)Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.