Revert: Restore icons.svg sprite injection in content_script.tsx#351
Merged
ujiro99 merged 2 commits intofeat/add-e2e-testcasesfrom Apr 1, 2026
Merged
Revert: Restore icons.svg sprite injection in content_script.tsx#351ujiro99 merged 2 commits intofeat/add-e2e-testcasesfrom
ujiro99 merged 2 commits intofeat/add-e2e-testcasesfrom
Conversation
Agent-Logs-Url: https://github.com/ujiro99/selection-command/sessions/62809eb8-3f85-40f5-ad66-5f55bb9812cb Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Addressing feedback on e2e test cases regarding Icon component removal
Revert: Restore icons.svg sprite injection in content_script.tsx
Apr 1, 2026
ujiro99
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iconcomponent references#icon-...<symbol>elements that must exist in the Shadow DOM. A prior commit removed the sprite injection, which would break icon rendering across the extension UI.Changes
import icons from "./icons.svg?raw"andshadow.innerHTML = icons— re-injects the SVG sprite into the shadow root before React renders/assets/icons.cssreference (was incorrectly changed tocomponents.css)console.logthat was added alongside the deletionIcon component → Lucide migration will be handled in a separate PR at that point the sprite injection can be cleanly removed.