Skip to content

3219 remove remnants of startup module #3220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkovari merged 4 commits into from
Jun 6, 2024
Merged

3219 remove remnants of startup module #3220

mkovari merged 4 commits into from
Jun 6, 2024

Conversation

@chris-ashe
Copy link
Collaborator

@chris-ashe chris-ashe commented Jun 6, 2024

Description

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

chris-ashe added 4 commits June 6, 2024 13:23
@chris-ashe
chore: Remove startup_variables module
a0fae27 
The startup_variables module has been deleted from the repository. This module contained global variables related to the plasma start-up model. The deletion was necessary as it is no longer needed in the codebase.
@chris-ashe
Remove startup variables from physics.py
80e4b1a
@chris-ashe
Remove startup_variables module
cc161ff
@chris-ashe
Remove variables from tests
2b5236a
@chris-ashe chris-ashe linked an issue Jun 6, 2024 that may be closed by this pull request
Remove remnants of startup module #3219
Closed
@chris-ashe chris-ashe self-assigned this Jun 6, 2024
@chris-ashe chris-ashe added the Redundancy Obsolete parts of the code that need removed label Jun 6, 2024
@chris-ashe chris-ashe requested a review from mkovari June 6, 2024 14:38
@mkovari mkovari merged commit 6e8b92a into main Jun 6, 2024
@chris-ashe chris-ashe deleted the 3219-remove-remnants-of-startup-module branch June 6, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkovari mkovari mkovari approved these changes

Assignees

@chris-ashe chris-ashe

Labels

Redundancy Obsolete parts of the code that need removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove remnants of startup module

3 participants

@chris-ashe @mkovari