Fix issue 957 - Calc of build_variables.dh_tf_inner_bore revised #3223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-ashe
reviewed
Jun 17, 2024
chris-ashe
approved these changes
Jun 17, 2024
Collaborator
chris-ashe
left a comment
chris-ashe
left a comment
There was a problem hiding this comment.
The changes follow the correct build configuration and so is good to merge
chris-ashe
deleted the
957-tf-vertical-bore-not-consistent-for-single-null-option
branch
chris-ashe
pushed a commit
that referenced
this pull request
Jul 8, 2024
Co-authored-by: Michael Kovari <michael.kovari@ukaea.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #957.
Checklist
I confirm that I have completed the following checks: