954 bootstrap current fraction scaling formula for steady state machines #3268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new bootstrap current fraction model based on the Sakai formula. The `bootstrap_fraction_sakai` method is implemented in the `Physics` class in the `physics.py` file. This model calculates the bootstrap fraction using a set of parameters such as plasma beta, bootstrap current coefficient, safety factor, neoclassical viscosity parameters, and epsilon. The formula is derived from the work of Sakai et al. [^1^]. [^1^]: Sakai, R., Fujita, T., Okamoto, A. (2019). Derivation of bootstrap current fraction scaling formula for 0-D system code analysis. Fusion Engineering and Design, 149, 111322. https://doi.org/10.1016/j.fusengdes.2019.111322
stuartmuldrew
requested changes
Aug 6, 2024
Collaborator
stuartmuldrew
left a comment
stuartmuldrew
left a comment
There was a problem hiding this comment.
Minor comment about diamagnetic current options
This commit modifies the `Physics` class in the `physics.py` file to update the calculation of the Sakai bootstrap current. The Sakai formula states that the ACCOME dataset used has the toroidal diamagnetic current included in the bootstrap current. Therefore, the commit removes the PROCESS calculated diamagnetic current from the bootstrap current calculation. This change improves the accuracy of the bootstrap current fraction model.
chris-ashe
force-pushed
the
954-bootstrap-current-fraction-scaling-formula-for-steady-state-machines
branch
from
ce787b5 to
f1414f4
Compare
…g the Sakai scaling
Collaborator
|
Thanks - a helpful piece of work. |
stuartmuldrew
approved these changes
Aug 9, 2024
Collaborator
stuartmuldrew
left a comment
stuartmuldrew
left a comment
There was a problem hiding this comment.
Happy with error message addition.
chris-ashe
deleted the
954-bootstrap-current-fraction-scaling-formula-for-steady-state-machines
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new model by Sakai et al has been implemented
This should be applicable for all aspect ratios.
Unit tests created for large tokamak and ST case
Sakai et al. says at the start of the paper that the dataset used to fit the model includes the toroidal diamagnetic current. Thus we remove the diamagnetic fraction from the calculated value when the function is called
Checklist
I confirm that I have completed the following checks: