Skip to content

Conversation

@j-a-foster
Copy link
Collaborator

@j-a-foster j-a-foster commented Oct 17, 2024

Description

Fixes avail_2 not modifying component lifetimes in line with the calculated availability and made sure costs.py uses calendar years not FPY.

Checklist

I confirm that I have completed the following checks:

  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@j-a-foster j-a-foster linked an issue Oct 17, 2024 that may be closed by this pull request
@j-a-foster j-a-foster requested a review from chris-ashe October 17, 2024 14:19
Merging main in to keep branch up to date.
Copy link
Collaborator

@chris-ashe chris-ashe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 48.27586% with 15 lines in your changes missing coverage. Please review.

Project coverage is 27.21%. Comparing base (b68ac63) to head (2a09f3a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
process/costs.py 33.33% 10 Missing ⚠️
process/availability.py 64.28% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3352      +/-   ##
==========================================
+ Coverage   27.11%   27.21%   +0.09%     
==========================================
  Files          76       76              
  Lines       17736    17756      +20     
==========================================
+ Hits         4810     4832      +22     
+ Misses      12926    12924       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-a-foster j-a-foster merged commit 0e4fe8b into main Oct 21, 2024
@chris-ashe chris-ashe deleted the 1105-lifetime-variables-definitions branch October 21, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lifetime variables definitions

4 participants