Skip to content

Conversation

@ajpearcey
Copy link
Collaborator

closes #1442

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 168 lines in your changes missing coverage. Please review.

Project coverage is 27.20%. Comparing base (42780a9) to head (9475ece).

Files with missing lines Patch % Lines
process/physics_functions.py 57.89% 80 Missing ⚠️
process/physics.py 38.88% 22 Missing ⚠️
process/stellarator.py 4.34% 22 Missing ⚠️
process/io/sankey_funcs.py 0.00% 17 Missing ⚠️
process/current_drive.py 23.07% 10 Missing ⚠️
process/io/plot_proc.py 0.00% 4 Missing ⚠️
process/pfcoil.py 0.00% 3 Missing ⚠️
process/plasma_geometry.py 0.00% 3 Missing ⚠️
process/hcpb.py 33.33% 2 Missing ⚠️
process/dcll.py 50.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3364      +/-   ##
==========================================
+ Coverage   27.11%   27.20%   +0.08%     
==========================================
  Files          77       76       -1     
  Lines       17816    17781      -35     
==========================================
+ Hits         4831     4837       +6     
+ Misses      12985    12944      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajpearcey ajpearcey requested a review from jonmaddock November 4, 2024 16:30
@ajpearcey ajpearcey changed the title WIP: Location 1 PF coils don't work if there is no CS Location 1 PF coils don't work if there is no CS Nov 5, 2024
Copy link
Contributor

@jonmaddock jonmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you either rebase this into a single commit or separate into the bug fix and error message addition to reduce the churn for this PR please. Otherwise fine.

@ajpearcey ajpearcey force-pushed the issue-1442-pf-coil-position-error branch from 12f54e5 to b7f699f Compare November 13, 2024 10:05
@ajpearcey
Copy link
Collaborator Author

I've rebased and collapsed the new changes into one commit. Let know if this is what you had in mind.

@jonmaddock
Copy link
Contributor

jonmaddock commented Nov 13, 2024

@ajpearcey I think the rebase has been performed incorrectly: there are now 84 changed files.

@ajpearcey
Copy link
Collaborator Author

Im dumb, so ill just bin the PR and start again. It'll be easier.

@ajpearcey
Copy link
Collaborator Author

this is now superseded by #3396

@ajpearcey ajpearcey closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Location 1 PF coils don't work if there is no CS

4 participants