-
Notifications
You must be signed in to change notification settings - Fork 17
3350 tool to automatically convert obsolete variables from input file #3397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3350 tool to automatically convert obsolete variables from input file #3397
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3397 +/- ##
==========================================
+ Coverage 27.71% 28.43% +0.71%
==========================================
Files 77 77
Lines 18084 19215 +1131
==========================================
+ Hits 5012 5463 +451
- Misses 13072 13752 +680 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
timothy-nunn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have found several bugs that its not unreasonable to expect will occur in real-world input files.
I need to additionally consider the merits of doing this in-situ while running PROCESS versus this being a script that produces another input file.
…ment. Modified parsing to find variables with spacing around equals. Added error for when there is a list of replacements
I modified this validate_input function and added a CLI argument "replace_obsolete"
Now if you pass this argument when you run PROCESS it will automatically convert the variables, spit out the conversion in the terminal and write a comment in the input file where the name was changed.