Skip to content

Conversation

@ym1906
Copy link
Collaborator

@ym1906 ym1906 commented Nov 14, 2024

I modified this validate_input function and added a CLI argument "replace_obsolete"

Now if you pass this argument when you run PROCESS it will automatically convert the variables, spit out the conversion in the terminal and write a comment in the input file where the name was changed.

@ym1906 ym1906 linked an issue Nov 14, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 9.52381% with 38 lines in your changes missing coverage. Please review.

Project coverage is 28.43%. Comparing base (d9801ca) to head (b979161).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
process/main.py 9.52% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3397      +/-   ##
==========================================
+ Coverage   27.71%   28.43%   +0.71%     
==========================================
  Files          77       77              
  Lines       18084    19215    +1131     
==========================================
+ Hits         5012     5463     +451     
- Misses      13072    13752     +680     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found several bugs that its not unreasonable to expect will occur in real-world input files.

I need to additionally consider the merits of doing this in-situ while running PROCESS versus this being a script that produces another input file.

…ment. Modified parsing to find variables with spacing around equals. Added error for when there is a list of replacements
@ym1906 ym1906 requested a review from timothy-nunn November 26, 2024 11:29
@timothy-nunn timothy-nunn merged commit 2be48a8 into main Dec 4, 2024
18 checks passed
@timothy-nunn timothy-nunn deleted the 3350-tool-to-automatically-convert-obsolete-variables-from-input-file branch December 4, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tool to automatically convert obsolete variables from input file

4 participants