Skip to content

Conversation

@chris-ashe
Copy link
Collaborator

@chris-ashe chris-ashe commented Mar 28, 2025

Description

Namespace changes

Variables

whttf -> m_tf_coils_total
aiwp -> a_tf_coil_wp_turn_insulation
bmaxtf -> b_tf_inboard_peak
theta_coil -> rad_tf_coil_toroidal
tfareain -> a_tf_coil_inboard
h_cp_top -> z_cp_top
tftort -> dx_tf_inboard_out_toroidal
tfc_current -> c_tf_coil
jwptf -> j_tf_wp
rbmax -> r_b_tf_inboard_peak
tfind -> ind_tf_coil
whtconsh -> m_tf_turn_steel
tmpcry -> temp_tf_cryo
thkcas -> dr_tf_nose_case
casths -> dx_tf_side_case
estotft -> e_tf_magnetic_stored_total

Functions

coilshap() -> tf_coil_shape_inner()

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 42.57426% with 58 lines in your changes missing coverage. Please review.

Project coverage is 36.13%. Comparing base (2d48ead) to head (b940ea7).
Report is 113 commits behind head on main.

Files with missing lines Patch % Lines
process/tf_coil.py 50.00% 22 Missing ⚠️
process/superconducting_tf_coil.py 48.14% 14 Missing ⚠️
process/stellarator.py 0.00% 10 Missing ⚠️
process/io/plot_proc.py 0.00% 5 Missing ⚠️
process/resistive_tf_coil.py 28.57% 5 Missing ⚠️
process/buildings.py 0.00% 1 Missing ⚠️
process/init.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3608   +/-   ##
=======================================
  Coverage   36.13%   36.13%           
=======================================
  Files          88       88           
  Lines       22106    22106           
=======================================
  Hits         7988     7988           
  Misses      14118    14118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe chris-ashe self-assigned this Mar 31, 2025
@chris-ashe chris-ashe added the TF Coil Toroidal field coil label Mar 31, 2025
@chris-ashe chris-ashe force-pushed the update_tf_variables_1 branch from 98e13e9 to 3e8b66f Compare April 7, 2025 13:03
@chris-ashe chris-ashe changed the title 🚧 Rename TF coil variables, part 1 Rename TF coil variables, part 1 Apr 8, 2025
@chris-ashe chris-ashe marked this pull request as ready for review April 8, 2025 09:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 60 out of 68 changed files in this pull request and generated 1 comment.

Files not reviewed (8)
  • examples/data/csv_output_large_tokamak_MFILE.DAT: Language not supported
  • examples/data/large_tokamak_1_MFILE.DAT: Language not supported
  • examples/data/large_tokamak_2_MFILE.DAT: Language not supported
  • examples/data/large_tokamak_3_MFILE.DAT: Language not supported
  • examples/data/large_tokamak_4_MFILE.DAT: Language not supported
  • examples/data/large_tokamak_IN.DAT: Language not supported
  • examples/data/scan_MFILE.DAT: Language not supported
  • examples/data/scan_example_file_IN.DAT: Language not supported

Copy link
Collaborator

@timothy-nunn timothy-nunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor issue with obsolete variables. Will also need to be rebased to main

@chris-ashe chris-ashe force-pushed the update_tf_variables_1 branch 2 times, most recently from 1aa3852 to 890b105 Compare April 9, 2025 13:00
@chris-ashe chris-ashe force-pushed the update_tf_variables_1 branch from 890b105 to 17868a0 Compare April 10, 2025 09:24
@chris-ashe chris-ashe force-pushed the update_tf_variables_1 branch from 67372ff to b940ea7 Compare April 10, 2025 09:31
@timothy-nunn timothy-nunn removed the request for review from j-a-foster April 10, 2025 09:41
@timothy-nunn timothy-nunn merged commit 5f6f680 into main Apr 10, 2025
14 of 18 checks passed
@timothy-nunn timothy-nunn deleted the update_tf_variables_1 branch April 10, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TF Coil Toroidal field coil

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants