-
Notifications
You must be signed in to change notification settings - Fork 17
TF coil plasma case area error #3748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3748 +/- ##
==========================================
+ Coverage 38.80% 40.26% +1.46%
==========================================
Files 92 93 +1
Lines 23336 24699 +1363
==========================================
+ Hits 9055 9945 +890
- Misses 14281 14754 +473 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
j-a-foster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with changes.
For the calculation of the superconducting inboard TF ($\cos\left(\frac{\pi}{N_{TF}}\right)$ term in the summation of the radial components. This seems non sensical as this term will always reduce the total value for the summed components. It was discovered that this was put in long ago to prevent the WP from clipping into the end of the plasma case no matter what the value was.
dr_tf_inboard) and WP thickness (dr_tf_wp_with_insulation) there was always aA better approach has been added that preserved the summation of the radial components and their total value. In the calculation of the radial thickness of the plasma case (
dr_tf_plasma_case) the same logic to prevent collision has been applied to create a minimum valueError Handling Enhancements:
dr_tf_plasma_caseis too small to accommodate the winding pack (WP), forcing it to a minimum value. This includes updates toerrorlist.jsonand logic intf_coil.py. [1] [2] [3]Visualization Improvements:
plot_proc.pyto markr_tf_inboard_out, improving clarity in TF coil visualizations.✅Tests
Below is the one of the regression test failures, notice how the area of the plasma case has gone down even though the radial thickness has increased.
This will hopefully close #1884 #1709
Checklist
I confirm that I have completed the following checks: