Skip to content

Conversation

@timothy-nunn
Copy link
Collaborator

Adds a new switch force_vmcon_inequality_satisfication that allows one to turn on "strict" inequality mode: where an additional convergence criteria is added to VMCON that ensures all inequality constraints are exactly satisfied.

By default, this will be off (returning PROCESS to how it was pre-#3240).

I have tested this with large_tokamak_nof which is now failing with --reg-tolerance = 0.0; setting force_vmcon_inequality_satisfication = 1 causes the test to pass.

@timothy-nunn timothy-nunn linked an issue Sep 19, 2025 that may be closed by this pull request
@timothy-nunn timothy-nunn changed the title Add switch to toggle inequality zero margin enforcer Add switch to toggle strict inequality convergence criteria in VMCON Sep 19, 2025
@timothy-nunn timothy-nunn self-assigned this Sep 19, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.67%. Comparing base (aff2888) to head (73f9de4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3858   +/-   ##
=======================================
  Coverage   46.67%   46.67%           
=======================================
  Files         122      122           
  Lines       27806    27809    +3     
=======================================
+ Hits        12978    12981    +3     
  Misses      14828    14828           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn merged commit 1412d67 into main Sep 25, 2025
14 of 18 checks passed
@timothy-nunn timothy-nunn deleted the 3777-inequality-equation-is-checked-without-any-margin branch September 25, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inequality equation is checked without any margin

4 participants