Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4133 +/- ##
==========================================
+ Coverage 47.51% 47.61% +0.09%
==========================================
Files 141 142 +1
Lines 29537 29968 +431
==========================================
+ Hits 14035 14268 +233
- Misses 15502 15700 +198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
je-cook
requested changes
Mar 24, 2026
Collaborator
je-cook
left a comment
je-cook
left a comment
There was a problem hiding this comment.
Mostly good, some small changes and a little bit of path rework please
Comment on lines
+66
to
+71
| # Copy the file to avoid polluting the project directory with example files | ||
| temp_dir = tempfile.TemporaryDirectory() | ||
| input_path = Path(temp_dir.name) / "large_tokamak_IN.DAT" | ||
| input_path2 = Path(temp_dir.name) / "large_tokamak_varied_min_net_electric_IN.DAT" | ||
| shutil.copy(input_file, input_path) | ||
| shutil.copy(input_file2, input_path2) |
Collaborator
There was a problem hiding this comment.
put this in a separate cell so the user can choose not to run it if they dont need to. Maybe also rework the use of paths slightly so it doesnt matter if they run it or not. The path to mfiles is remade quite a few times
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3920
I have removed the call to mfile_to_csv from introduction.ex.py as part of this PR as it was not adding anything of value to the notebook.
Checklist
I confirm that I have completed the following checks: