Skip to content

Pf coils accounting pr#4182

Merged
timothy-nunn merged 26 commits intomainfrom
pf-coils-accounting-pr
Apr 13, 2026
Merged

Pf coils accounting pr#4182
timothy-nunn merged 26 commits intomainfrom
pf-coils-accounting-pr

Conversation

@grmtrkngtn
Copy link
Copy Markdown
Collaborator

@grmtrkngtn grmtrkngtn commented Apr 13, 2026

Description

Closes #972 #4089

pdates pfpwr equation to account for additional components in pf power management: busbar, power supply and storage system.

We have added separate functions to calculate the power loss for each component.
pfpwr has been adapted to use these new functions to account for the pf power supply - previously they were lumped into one value.
A mild refactor of pfpwr function (modularising it a bit, renaming some variables)

from #972 and #4089

Checklist

I confirm that I have completed the following checks:

  • [x ] My changes follow the PROCESS style guide
  • [ x] I have justified any large differences in the regression tests caused by this pull request in the comments.
  • [ x] I have added new tests where appropriate for the changes I have made.
  • [ x] If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • [x ] If I have made documentation changes, I have checked they render correctly.
  • [x ] I have added documentation for my change, if appropriate.

@grmtrkngtn grmtrkngtn requested a review from a team as a code owner April 13, 2026 15:36
@grmtrkngtn grmtrkngtn requested a review from timothy-nunn April 13, 2026 15:37
@timothy-nunn timothy-nunn self-assigned this Apr 13, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.63%. Comparing base (2899a60) to head (6b6d138).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4182      +/-   ##
==========================================
+ Coverage   49.56%   49.63%   +0.06%     
==========================================
  Files         148      148              
  Lines       29719    29757      +38     
==========================================
+ Hits        14731    14769      +38     
  Misses      14988    14988              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn
Copy link
Copy Markdown
Collaborator

timothy-nunn commented Apr 13, 2026

Moved from #4089 (which was approved) due to rebase

@timothy-nunn timothy-nunn merged commit 728f5f4 into main Apr 13, 2026
8 of 10 checks passed
@timothy-nunn timothy-nunn deleted the pf-coils-accounting-pr branch April 13, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PF power supplies accounting 2

5 participants