-
Notifications
You must be signed in to change notification settings - Fork 18
🧲 Refactor croco 3 #4246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
🧲 Refactor croco 3 #4246
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
9689215
Add CROCOAveragedTurnGeometry class and update CROCOSuperconductingTF…
chris-ashe b00e475
Remove unused i_tf_sc_mat parameter from CICCSuperconductingTFCoil an…
chris-ashe 42045f6
Refactor CICCSuperconductingTFCoil to simplify cable calculations by …
chris-ashe c220f4f
Update main_plot to handle different superconducting turn types and i…
chris-ashe 2a9e3b0
Add output_croco_info method to CROCOSuperconductingTFCoil for detail…
chris-ashe 9451817
Add plot_tf_croco_turn function for visualizing TF coil CICC turn str…
chris-ashe 0c957e9
Remove unsupported integer turn geometry handling for CroCo conductor…
chris-ashe 641d0e8
Refactor CROCOSuperconductingTFCoil to streamline conductor area calc…
chris-ashe 5c4f325
Post rebase summary file changes
chris-ashe c8dcf71
Add effective cable space area calculation in CROCOSuperconductingTFCoil
chris-ashe cbdaf8c
Refactor CROCOSuperconductingTFCoil to update Croco cable diameter va…
chris-ashe b02aed9
Enhance CroCo cable geometry calculations by adding tape stack height…
chris-ashe c799163
Add CroCo cable geometry data class and summary box for plotting
chris-ashe e9a154b
Add HTS tape geometry plotting function and update CroCo cable plot p…
chris-ashe 0004dfc
Refactor CroCo strand calculations to use N_CROCO_STRANDS_TURN consta…
chris-ashe b5f7754
Refactor CroCo cable geometry calculations to return CroCoCableGeomet…
chris-ashe 30d4c7a
Refactor CROCOSuperconductingTFCoil to utilize calculate_croco_cable_…
chris-ashe 34d0783
Refactor variable names for TF coil components
chris-ashe be7a6c8
Update tests
chris-ashe 027aa18
Rename croco superconductor
chris-ashe 43fda6c
Pass out function terms
chris-ashe 593a759
Add CroCoCableSpaceGeometry class and refactor cable space calculatio…
chris-ashe 9ed0673
Add TFSuperconductorLimits dataclass and refactor superconductor prop…
chris-ashe 37f2d0e
Refactor CroCo cable geometry calculations and remove deprecated croc…
chris-ashe 4087e66
Refactor jcrit_rebco function to return additional critical propertie…
chris-ashe bd4eaef
Refactor CroCo copper bar area variable and update related calculatio…
chris-ashe 0440e2b
Refactor CroCo strand critical current variable and update related ca…
chris-ashe 48c3019
Refactor CroCo copper area variables and update related calculations …
chris-ashe 5590aad
Rename `conductor_hastelloy_area` to `a_tf_turn_croco_hastelloy`
chris-ashe 915049d
Refactor superconductor classes to add type hints and clean up unused…
chris-ashe 77bb095
Update tests
chris-ashe ac0129f
Refactor output methods in TFCoil classes to use output_general_tf_in…
chris-ashe 0282963
Move `e_tf_magnetic_stored_total` variable from superconducting to n…
chris-ashe c004cdf
Rename `oacdcp` to `j_tf_coil_full_area` across multiple files for cl…
chris-ashe 0c06129
Update TF coil variable descriptions for clarity and consistency
chris-ashe a74ba42
Refactor TFCoil output methods to use instance outfile and add genera…
chris-ashe 6d384f8
Post rebase changes
chris-ashe 1087377
Enhance output methods for resistive and superconducting TF coils, ad…
chris-ashe b56b932
Enhance SuperconductingTFTurnType enum to include full names and impr…
chris-ashe 607322b
Refactor radial build output methods for resistive and superconductin…
chris-ashe a49c400
Add detailed resistive loss parameters output for ResistiveTFCoil class
chris-ashe f469850
Enhance output structure and clarity for SuperconductingTFCoil class
chris-ashe 01e504c
Refactor output methods for CroCo superconducting TF coil, enhancing …
chris-ashe 07fe58b
Add dx_tf_hts_tape_total to CroCoCableGeometry and update CROCOSuperc…
chris-ashe 1b22ae4
Fix calculation of internal diameter in CroCo cable geometry by adjus…
chris-ashe ebe9e99
Post rebase fixes
chris-ashe 02e8492
Update process/core/input.py
chris-ashe 41ba685
Update obsoelete vars
chris-ashe 3f1c312
Requested changes
chris-ashe 436f46f
Refactor stress calculation in SuperconductingTFCoil class and stream…
chris-ashe 06804f0
Post rebase changes
chris-ashe 913930a
Fix rebco_variables attribute name for copper current density in quen…
chris-ashe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.