Skip to content

Convert IFE vars to dataclass#4254

Merged
timothy-nunn merged 1 commit into
mainfrom
IFE-Dataclass
May 15, 2026
Merged

Convert IFE vars to dataclass#4254
timothy-nunn merged 1 commit into
mainfrom
IFE-Dataclass

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented May 15, 2026

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould mentioned this pull request May 15, 2026
64 tasks
@clmould clmould marked this pull request as ready for review May 15, 2026 09:38
@clmould clmould requested a review from a team as a code owner May 15, 2026 09:38
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 15, 2026

Codecov Report

❌ Patch coverage is 91.32841% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.47%. Comparing base (4290d86) to head (7ee297f).

Files with missing lines Patch % Lines
process/models/ife.py 90.56% 25 Missing ⚠️
process/models/costs/costs.py 40.00% 18 Missing ⚠️
process/core/caller.py 25.00% 3 Missing ⚠️
process/core/output.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4254      +/-   ##
==========================================
- Coverage   50.66%   50.47%   -0.19%     
==========================================
  Files         151      151              
  Lines       29615    29504     -111     
==========================================
- Hits        15004    14893     -111     
  Misses      14611    14611              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn added the Data structure Issues related to the data structure label May 15, 2026
@timothy-nunn timothy-nunn merged commit fe3e0ab into main May 15, 2026
10 of 11 checks passed
@timothy-nunn timothy-nunn deleted the IFE-Dataclass branch May 15, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Data structure Issues related to the data structure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants