Skip to content

Convert impurity radiation data structure to dataclass#4264

Merged
clmould merged 2 commits into
mainfrom
impurity-radiation-dataclass
May 21, 2026
Merged

Convert impurity radiation data structure to dataclass#4264
clmould merged 2 commits into
mainfrom
impurity-radiation-dataclass

Conversation

@timothy-nunn
Copy link
Copy Markdown
Collaborator

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 20, 2026

Codecov Report

❌ Patch coverage is 81.70732% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.13%. Comparing base (11881e8) to head (0e7bc7d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
process/models/physics/physics.py 65.00% 7 Missing ⚠️
process/core/scan.py 0.00% 5 Missing ⚠️
process/core/io/plot/summary.py 50.00% 1 Missing ⚠️
process/models/physics/impurity_radiation.py 94.11% 1 Missing ⚠️
process/models/physics/radiation_power.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4264   +/-   ##
=======================================
  Coverage   50.13%   50.13%           
=======================================
  Files         151      151           
  Lines       29343    29345    +2     
=======================================
+ Hits        14710    14712    +2     
  Misses      14633    14633           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn force-pushed the impurity-radiation-dataclass branch from 0a3f3ec to 72e3ee7 Compare May 20, 2026 13:20
@timothy-nunn timothy-nunn force-pushed the impurity-radiation-dataclass branch from 72e3ee7 to 0d4677c Compare May 20, 2026 13:27
@timothy-nunn timothy-nunn marked this pull request as ready for review May 20, 2026 13:32
@timothy-nunn timothy-nunn requested a review from a team as a code owner May 20, 2026 13:32
@timothy-nunn timothy-nunn added the Data structure Issues related to the data structure label May 20, 2026
Comment thread process/data_structure/impurity_radiation_variables.py
Comment thread process/core/solver/iteration_variables.py Outdated
Comment thread process/models/physics/impurity_radiation.py
@clmould clmould merged commit 5cad514 into main May 21, 2026
10 of 11 checks passed
@clmould clmould deleted the impurity-radiation-dataclass branch May 21, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Data structure Issues related to the data structure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants