Skip to content

Convert superconducting tf variables to dataclass#4281

Merged
timothy-nunn merged 2 commits into
mainfrom
Superconducting-TF-Dataclass
Jun 2, 2026
Merged

Convert superconducting tf variables to dataclass#4281
timothy-nunn merged 2 commits into
mainfrom
Superconducting-TF-Dataclass

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented Jun 2, 2026

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@clmould clmould requested a review from a team as a code owner June 2, 2026 12:35
@clmould clmould mentioned this pull request Jun 2, 2026
71 tasks
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 2, 2026

Codecov Report

❌ Patch coverage is 67.31392% with 101 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.81%. Comparing base (77f8d67) to head (1b366bc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
process/models/tfcoil/superconducting.py 9.37% 87 Missing ⚠️
process/core/caller.py 12.50% 7 Missing ⚠️
process/models/tfcoil/base.py 16.66% 5 Missing ⚠️
process/models/stellarator/coils/quench.py 0.00% 1 Missing ⚠️
process/models/tfcoil/resistive.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4281      +/-   ##
==========================================
- Coverage   48.95%   48.81%   -0.15%     
==========================================
  Files         151      151              
  Lines       29180    29097      -83     
==========================================
- Hits        14286    14203      -83     
  Misses      14894    14894              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould force-pushed the Superconducting-TF-Dataclass branch from 39ac52e to ed1e1ed Compare June 2, 2026 13:00
@timothy-nunn timothy-nunn enabled auto-merge (squash) June 2, 2026 15:19
@timothy-nunn timothy-nunn merged commit 906cf7d into main Jun 2, 2026
10 of 11 checks passed
@timothy-nunn timothy-nunn deleted the Superconducting-TF-Dataclass branch June 2, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants