Update timeout configuration to use time.Duration for consistency#53
Merged
Update timeout configuration to use time.Duration for consistency#53
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the timeout configuration across various modules to use time.Duration for consistency. It also refactors tests to use table-driven subtests for improved clarity and coverage.
- Updated UReadability instantiation in production and test code to use time.Duration.
- Refactored tests in readability_test.go to adopt table-driven subtests for multiple URL scenarios.
- Revised all timeout specifications in backend/main.go, backend/rest/server_test.go, and extractor packages for consistency.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| backend/extractor/readability_test.go | Updated timeout configuration and refactored tests into a table-driven approach. |
| backend/main.go | Changed timeout from an integer value to a proper time.Duration for UReadability. |
| backend/rest/server_test.go | Updated timeout definitions to reflect the new time.Duration configuration. |
| backend/extractor/readability.go | Removed unnecessary multiplication with time.Second, relying directly on the already set time.Duration. |
| backend/extractor/pics_test.go & pics.go | Ensured timeout fields use time.Duration consistently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.