python: Add new functions unique() and relabelConsecutive()#339
Merged
ukoethe merged 5 commits intoukoethe:version-1-11-rcfrom Feb 28, 2016
Merged
python: Add new functions unique() and relabelConsecutive()#339ukoethe merged 5 commits intoukoethe:version-1-11-rcfrom
ukoethe merged 5 commits intoukoethe:version-1-11-rcfrom
Conversation
stuarteberg
force-pushed
the
add-relabel-consecutive
branch
2 times, most recently
from
94a5ea8 to
bcb412d
Compare
stuarteberg
force-pushed
the
add-relabel-consecutive
branch
2 times, most recently
from
6ae1dc5 to
3030e28
Compare
stuarteberg
force-pushed
the
add-relabel-consecutive
branch
from
3030e28 to
d8fbeef
Compare
vigranumpy/src/core/segmentation.cxx
Outdated
| NumpyAnyArray | ||
| pythonUnique(NumpyArray<NDIM, Singleband<VoxelType> > src) | ||
| { | ||
| boost::unordered_set<VoxelType> labelset; |
Owner
There was a problem hiding this comment.
Is there a reason to prefer boost:: over std:: here?
stuarteberg
force-pushed
the
add-relabel-consecutive
branch
from
cf8a7e6 to
e22a0ef
Compare
stuarteberg
force-pushed
the
add-relabel-consecutive
branch
from
e22a0ef to
4921270
Compare
Contributor
Author
|
Thanks again for the careful review. I've updated the code to implement your suggestions. |
ukoethe
added a commit
that referenced
this pull request
Feb 28, 2016
python: Add new functions unique() and relabelConsecutive()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two more functions that are helpful when dealing with huge label volumes. This implementation of
unique()is 3x faster thannumpy.unique(). Similarly, this implementation ofrelabelConsecutive()is much faster than the best python implementation I could come up with.