bugfix/fix-flaky-aiohttp-unit-tests#200
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
6115092 to
c93e359
Compare
Signed-off-by: DBT pre-commit check
c93e359 to
54bbaba
Compare
SamW94
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
aio_client_factoryfixture to use the asyncio loop created by the unit test inside the aiohttp test client. When this code is missing, the aiohttp code might use a different task loop than the test which causes flaky tests.asyncio_mode = "auto"to auto run async tests without needing to use apytest.markstatementContributors
Let's acknowledge the people who contributed to the work.
Type of change
How this has been tested
Please describe the tests that you ran to verify your changes.
If they are not automated tests please explain why and provide screenshots and/or instructions so they can reproduced.
Checklist
Reviewer Checklist