This repository was archived by the owner on Jan 30, 2024. It is now read-only.
[m multi-select] Supporter la prop Options à undefined #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckmah
suggested changes
Nov 5, 2020
| options: undefined | ||
| }), | ||
| template: `<m-multi-select @open="open" @close="close" @focus="focus" @blur="blur" @select-item="select" :options="options" v-model="model1"></m-multi-select>` | ||
| }) |
Contributor
There was a problem hiding this comment.
les actions ne sont pas nécessaire ici ca fait juste du bruit dans le html (copier / coller ?)
Aussi j'aurais preferer un test unitaire au storybook pour ca cas vu qu'on devrait tester les cas onKeydownEnter onKeydownSpace etc....
chuckmah
approved these changes
Nov 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
La prop Options provient parfois d'un appel async a un service. La valeur des options peut alors être temporaire undefined en attendant que les options soient obtenus. Une erreur était alors obtenu. Ce changement permet de supporter options=undefined. Il se comporte comme dans les cas options=[]
Types de changements
breaking change)breaking change)breaking change)Comment cela peut-il être testé?
Inclure cette section dans les release notes
Liens internes