Merged
Conversation
calebjclark
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: tests won't run without the @ulixee/payments PR being pulled into main first
This PR converts Databox to use the simplified gift cards scheme. It also adds cli commands to:
@ulixee/databox gift-cards create -m 100c -d ./databox.jscreate a gift card for the existing databox. This process looks up "gift card issuers" installed on the local machine and puts it into a local manifest file for the databox (or uses the existing issuer).@ulixee/databox gift-cards list-issuersshould locally installed "issuer identities". Basically the signing proof that this is a real gift card@ulixee/databox gift-cards create-issuercreate a new issuer for a gift card (stores in /ulixee/gift-card-issuersThis PR also makes it so a miner does not have to do anything to participate in gift cards. There are two options:
giftCardsAllowedSet tofalseto disable any gift card usage. It's true by default, but a miner might choose to explicitly turn it off.giftCardsRequiredIssuerIdentity: An additional security feature requiring a gift card to be signed by both the miner AND the databox in order for the miner to accept it. This would be used if a miner wanted to limit the amount of gift cards a databox author gave out