chore(miner): enable registering for shutdown#145
Merged
calebjclark merged 1 commit intomainfrom Nov 28, 2022
Merged
Conversation
blakebyrnes
force-pushed
the
shutdown
branch
2 times, most recently
from
b810681 to
ec4d062
Compare
calebjclark
reviewed
Nov 28, 2022
| private readonly wsRoutes: [RegExp | string, IWsHandleFn][] = []; | ||
|
|
||
| constructor(addressHost = 'localhost') { | ||
| constructor(addressHost = 'localhost', shouldShutdownOnSignals = true) { |
Contributor
There was a problem hiding this comment.
It seems the second argument should be an options object, same as Hero. I'm going to go ahead and merge though.
blakebyrnes
force-pushed
the
shutdown
branch
from
ec4d062 to
1934c80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow a user to control whether Miner auto-shuts down.