Conversation
| @@ -0,0 +1,2 @@ | |||
| export type IInputFilter = Record<string, any>; | |||
There was a problem hiding this comment.
Is this "any" something we should add typing to later? Or is it meant to just be literally anything?
There was a problem hiding this comment.
Yeah, we will add typing to this later.
client/main/lib/ClientForRemote.ts
Outdated
There was a problem hiding this comment.
This typing is confusing me. Does it actually narrow types that are input or output? Seems to just say, this extends basically anything, and defaults to anything.
There was a problem hiding this comment.
It's just a placeholder. We need to download and support schemas from remote datastores.
| }); | ||
| } | ||
| throw ValidationError.fromZodValidation( | ||
| `The API parameters for ${command} have some issues`, |
There was a problem hiding this comment.
Isn't the "have" because it's "The api parameterS"?
There was a problem hiding this comment.
Maybe? Definitely if it said, "The ${command}'s API parameters have...", but I'm not sure about the "API parameters for ${command}". The wording felt weird when I first saw the error.
| const boundValues: string[] = []; | ||
|
|
||
| for (const field of Object.keys(request.input || {})) { | ||
| const value = request.input[field]; |
There was a problem hiding this comment.
Seems like a SQL injection attack vector here without checking these fields.
There was a problem hiding this comment.
Can we chat about this?
2 participants
No description provided.