Rough working version of selector generator #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakebyrnes
reviewed
Nov 12, 2021
| this.getDevtoolsTabId.bind(this, devtoolsSession), | ||
| devtoolsSession.send('Runtime.runIfWaitingForDebugger'), | ||
| ]).catch(() => null); | ||
| // (${interceptElementOverlayDispatches.toString()})('${___sendToCore}', '${MessageEventType.CloseElementOptionsOverlay}'); |
Contributor
There was a problem hiding this comment.
meant to be commented out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the Selector Generator with the built-in Devtools Element Selector.
It also extends the right-click contextMenu inside the Devtools Elements Panel (right click on any element to add/remove from Selector Generator).
The actual Selector Generator is missing everything except Single Element selectors. In order to push a working version I had to rollback all of my Multiple Elements selector code. This also rolled back the ability to remove selector parts (i.e., cutting an ID from selectors).
Finally, there is zero integration with Multiverses.