feat: added typed input/output to databox + other improvements #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed CollectedElements#getMeta → getMetaObjects. Seemed clearer, but I can revert this if you disagree.
Added CollectedElements#findMetaObjectByElement
Added optional typing to new Databox<IDataboxInput, IDataboxOutput>. Typing is now required for Runner and Extractor classes.
Added optional
defaults:{ hero, input, output }object to Databox.Refactored how DataboxInternal and DomExtenders are connected. WeakMap is still used, but now it connects DataboxInternal to the Hero instances instead of CoreSession. This allows for hero.use(plugin) to be used within Databoxes.
Removed the
pluginsobject from Databox.