feat: Add Bing as a Picture of the Day option#449
Merged
Conversation
Signed-off-by: Magnus Ullberg <magnus@ullberg.us>
github-actions
Bot
added
area/backend
Contributor
Test Results - JVM241 tests 233 ✅ 8s ⏱️ Results for commit b0f50f2. ♻️ This comment has been updated with latest results. |
Contributor
Test Results - Native241 tests 233 ✅ 7s ⏱️ Results for commit b0f50f2. ♻️ This comment has been updated with latest results. |
Signed-off-by: Magnus Ullberg <magnus@ullberg.us>
… and height refactor(Background): modify fetchBingImage to use updated query structure fix(package-lock): remove unnecessary peer dependencies for graphql and graphql-ws Signed-off-by: Magnus Ullberg <magnus@ullberg.us>
Contributor
|
Pull Request closed and locked due to lack of activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Bing Image of the Day as a new background picture option, expanding the available background choices for users alongside the existing Unsplash integration.
Changes Made
Backend
BingImageGraphQLResource- Provides a GraphQL endpoint to fetch Bing's daily imageBingImageService- Handles fetching and caching the Bing Image of the DayBingImage- Data model for Bing image informationstartpunkt.bing.imageOfTheDayUrltoapplication.yamlFrontend
bingImagequery to fetch Bing's daily imageuseBackgroundPreferencesto handle Bing image preferencesTesting
useBackgroundPreferencestests to cover Bing functionalityFiles Changed
pom.xml- Dependencies (if any were added)src/main/java/us/ullberg/startpunkt/graphql/BingImageGraphQLResource.java(new)src/main/java/us/ullberg/startpunkt/objects/bingimage/BingImage.java(new)src/main/java/us/ullberg/startpunkt/service/BingImageService.java(new)src/main/resources/application.yaml- Configurationsrc/main/resources/i8n/en-US.json- English translationssrc/main/resources/i8n/sv-SE.json- Swedish translationssrc/main/webui/src/Background.jsx- UI componentsrc/main/webui/src/Background.test.jsx- Testssrc/main/webui/src/BackgroundSettings.jsx- Settings UIsrc/main/webui/src/graphql/queries.js- GraphQL queriessrc/main/webui/src/useBackgroundPreferences.js- React hooksrc/main/webui/src/useBackgroundPreferences.test.js- Hook testsTesting Checklist
./mvnw verifypassesType of Change
Signed-off-by: Magnus Ullberg magnus@ullberg.us