Add skeleton loader - In honor of Halloween! 💀 🎃#464
Merged
Conversation
Signed-off-by: Magnus Ullberg <magnus@ullberg.us>
Contributor
Contributor
Contributor
|
Pull Request closed and locked due to lack of activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👻 Spooky Scary Skeletons!
This PR adds a skeleton loader to give users a spook-tacular loading experience - just in time to celebrate Halloween (which was only a few days ago)! 🎃
🦴 What's New
🎃 Implementation Details
Component Architecture:
ApplicationandApplicationGroupcomponents withskeleton={true}propReal Mock Data:
Technical Highlights:
nameLength * 8px(uppercase text)wordLength * 6pxwidth🧪 Testing
🎭 Why "Skeleton" Loader?
Because what's Halloween without some friendly skeletons? This loader is here to make sure your users never see a dead page while waiting for data to load. It's a real no-brainer for improving perceived performance!
This PR is dedicated to all the ghosts, ghouls, and skeletons who visited us this past Halloween. May your loading states be ever spooky! 👻💀🎃