Repository navigation
Replies: 4 comments 2 replies
|
Thank you - glad it clicked. Let me go through the five, because they are not all the same size and two are closer than you'd think. 3. Clock while the screensaver runs - this is the one I'd do first. A photo frame that hides the time is the wrong trade for a wall-mounted tablet, which is where the screensaver mostly runs. Today only the photo's own date is drawn. Making it optional is right; the interesting question is whether it should follow the wall-mode clock settings rather than getting its own switch, so a household configures the time display once. 2. contain vs cover - 1. Trigger manually from the overview - the mechanism already exists: 5. Slow zoom (Ken Burns) - possible, but it comes with a measured cost. #716 was exactly this: continuous motion plus a 4. A photo tile on the overview - the biggest of the five and the one I am least sure about. The overview is the page that has to stay readable at a glance; a photo tile competes with everything around it for attention in a way the other four don't. Not a no, but it needs a design answer rather than a settings toggle. No promises on timing - I'm keeping this open as the tracking thread for the screensaver as a whole rather than splitting it into five. If you end up wanting one of them badly enough to have a preference on the details, say so here and it moves up. |
|
Adding one more to this thread, since it's the screensaver's tracking discussion: a configurable idle delay before the screensaver starts. Use case. I run Yuvomi on a dedicated wall photo frame (an old Android frame showing the dashboard full-screen). It's a display first and a touch device second - most of the day nobody touches it, and when someone does, it's to check one thing and walk away. Five minutes of a static dashboard before the photos come back is long on that kind of device; for us one minute is right. On a kitchen tablet that people actually work on, five minutes is probably still the better default, which is why I'd want it adjustable rather than just shorter. Why I think it's small. const IDLE_MS = Math.max(30, Number.parseInt(document.documentElement.dataset.screensaverIdle || '300', 10)) * 1000;but nothing sets What I'd propose, keeping in mind your note that the wall tablet's options should be configured once rather than gaining one-off switches:
If that direction works for you, I'm happy to open the PR - with all locales, tests and a CHANGELOG entry per CONTRIBUTING.md. Full disclosure as the guide asks: this comment and any PR would be drafted with Claude Code and reviewed by me. Thanks for the screensaver in the first place - it's what made Yuvomi the right fit for the frame. |
|
@nomi25home You read the code correctly. The component takes the delay from On where the setting lives, your own example decides it, I think. A photo frame that should start after one minute and a kitchen tablet that should wait five are two devices in the same household. A household setting in Wall mode had the same question and answers it per device: it is stored in the browser, because the wall tablet usually runs on a shared account and a server-side value would switch everybody's phone along with it. The idle delay is the same kind of value. So the direction I would take:
Two details for a PR in that shape. The component reads the delay once when it loads, so a changed value should take effect without a reload. And the page-head script repeats its storage keys as literals, with a guard in the frontend audit that keeps them in step with their source - a new key belongs in both places. The cost of this shape is that you set it once on the frame itself instead of at container start. For a frame without a usable keyboard that is one visit to the settings page; if that is a real obstacle on your device, say so, because it is the one argument for a server-side value. If that works for you, a PR is welcome. Thanks for the disclosure and for reading CONTRIBUTING first. |
|
@nomi25home The idle delay is merged as #1665 - thank you for the work and for the patience through the review rounds. It ships with the next release; this thread stays open for the other screensaver points. |
Uh oh!
There was an error while loading. Please reload this page.
First of all - what an awesome project! Just discovered it recently, and I'm already super hooked!
I was totally happy when I found out about the immich integration as screensaver.
New feature requests regarding immich/screensaver:
Just leave it here as ideas. Maybe that's inspiration for future releases!
All reactions