Skip to content

Core: Fix LaunchWebBrowser on macOS to handle addresses with dolar sign.#342

Merged
mirek-fidler merged 1 commit into
masterfrom
klugier/link-with-dolars-handling-on-macos
Jan 9, 2026
Merged

Core: Fix LaunchWebBrowser on macOS to handle addresses with dolar sign.#342
mirek-fidler merged 1 commit into
masterfrom
klugier/link-with-dolars-handling-on-macos

Conversation

@klugier
Copy link
Copy Markdown
Member

@klugier klugier commented Jan 6, 2026

In TheIDE handling for these links doesn't work as expected:

menu.AddMenu("Online documentation..", IdeImg::Go_forward(), callback1(LaunchWebBrowser, "http://www.ultimatepp.org/www$uppweb$documentation$en-us.html"));
menu.AddMenu("Common information..", IdeImg::Go_forward(), callback1(LaunchWebBrowser, "http://www.ultimatepp.org/www$uppweb$community$en-us.html"));

The solution is to escape $ dolar signs.

@klugier klugier requested a review from mirek-fidler January 6, 2026 13:23
@klugier klugier added bug important Important issue that should be review and merged promptly. labels Jan 7, 2026
@mirek-fidler mirek-fidler merged commit bfc8421 into master Jan 9, 2026
3 checks passed
@mirek-fidler mirek-fidler deleted the klugier/link-with-dolars-handling-on-macos branch January 9, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug important Important issue that should be review and merged promptly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants