Remove uv setup warnings from domain check workflow#297
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
PR looks clean. Replacing uv pip install --system requests with python -m pip install requests after actions/setup-python should preserve the workflow behavior while removing the extra setup step and its warnings. I didn't find any actionable issues in this diff.
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
|
Merged—fantastic improvement, @glenn-jocher! 🎉 “Simplicity is the ultimate sophistication.” — Leonardo da Vinci This PR is a great example of that idea in action: trimming extra tooling, pinning Python 3.14, and making the domain-check workflow more predictable and maintainable. Small CI refinements like this quietly strengthen the contributor experience for everyone. Thank you for continuing to make the Ultralytics docs infrastructure cleaner, more reliable, and easier to build on—your attention to these details really matters. 🙌 |
Summary
astral-sh/setup-uvfromcheck_domains.ymlrequestswithpython -m pipinsteadWhy
setup-uvis the source of the repeated cache, dependency-glob, and empty-workdir warnings in this workflow. This job only needs Python andrequests, souvis unnecessary here.Testing
python3 -m pip --versiongit diff --check -- .github/workflows/check_domains.yml🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
🛠️ This PR simplifies the domain-checking GitHub Action by removing
uvsetup and switching to a directpipinstall on Python 3.14.📊 Key Changes
.github/workflows/check_domains.yml.3.x) to a fixed version: Python 3.14.astral-sh/setup-uvstep entirely.uv pip install --system requestswith a standardpython -m pip install requests.🎯 Purpose & Impact
uvlowers complexity and avoids relying on an additional package manager for a very small install.