Skip to content

Remove uv setup warnings from domain check workflow#297

Merged
glenn-jocher merged 2 commits intomainfrom
codex/remove-uv-from-domain-check
Apr 16, 2026
Merged

Remove uv setup warnings from domain check workflow#297
glenn-jocher merged 2 commits intomainfrom
codex/remove-uv-from-domain-check

Conversation

@glenn-jocher
Copy link
Copy Markdown
Member

@glenn-jocher glenn-jocher commented Apr 16, 2026

Summary

  • remove astral-sh/setup-uv from check_domains.yml
  • install requests with python -m pip instead

Why

setup-uv is the source of the repeated cache, dependency-glob, and empty-workdir warnings in this workflow. This job only needs Python and requests, so uv is unnecessary here.

Testing

  • python3 -m pip --version
  • git diff --check -- .github/workflows/check_domains.yml

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

🛠️ This PR simplifies the domain-checking GitHub Action by removing uv setup and switching to a direct pip install on Python 3.14.

📊 Key Changes

  • Updated the GitHub Actions workflow in .github/workflows/check_domains.yml.
  • Changed the Python setup from a floating version (3.x) to a fixed version: Python 3.14.
  • Removed the astral-sh/setup-uv step entirely.
  • Replaced uv pip install --system requests with a standard python -m pip install requests.

🎯 Purpose & Impact

  • Simpler CI workflow: Fewer setup steps make the action easier to understand and maintain.
  • Reduced dependency on extra tooling: Removing uv lowers complexity and avoids relying on an additional package manager for a very small install.
  • 🔒 More predictable runs: Pinning to Python 3.14 helps ensure consistent behavior across workflow executions.
  • 👥 Low user-facing impact: This is mainly an internal documentation/CI maintenance improvement, but it can make automated checks more reliable for contributors.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Apr 16, 2026 5:57pm

Request Review

@UltralyticsAssistant UltralyticsAssistant added dependencies Dependencies and packages devops GitHub Devops or MLops labels Apr 16, 2026
@UltralyticsAssistant
Copy link
Copy Markdown
Member

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/docs 🚀 PR! This is an automated message to help with review readiness, and an engineer will assist you shortly. Please review the checklist below for a smooth integration 😊

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/docs main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

Copy link
Copy Markdown
Member

@UltralyticsAssistant UltralyticsAssistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

PR looks clean. Replacing uv pip install --system requests with python -m pip install requests after actions/setup-python should preserve the workflow behavior while removing the extra setup step and its warnings. I didn't find any actionable issues in this diff.

Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
@glenn-jocher glenn-jocher merged commit 8306e39 into main Apr 16, 2026
4 checks passed
@glenn-jocher glenn-jocher deleted the codex/remove-uv-from-domain-check branch April 16, 2026 17:57
@UltralyticsAssistant
Copy link
Copy Markdown
Member

Merged—fantastic improvement, @glenn-jocher! 🎉

Simplicity is the ultimate sophistication.” — Leonardo da Vinci

This PR is a great example of that idea in action: trimming extra tooling, pinning Python 3.14, and making the domain-check workflow more predictable and maintainable. Small CI refinements like this quietly strengthen the contributor experience for everyone.

Thank you for continuing to make the Ultralytics docs infrastructure cleaner, more reliable, and easier to build on—your attention to these details really matters. 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependencies and packages devops GitHub Devops or MLops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants