Tighten live-site spellcheck false positives#321
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Good cleanup overall, but there are two correctness issues to address before this achieves its goal: the new docs exclusion regex is malformed in both workflows, and the expanded global codespell allowlist now suppresses at least one clear typo that should still be caught.
💬 Posted 3 inline comments
d9380da to
d7a89e5
Compare
|
Resolved the stale review findings in commit d7a89e5. This PR no longer suppresses source bugs like |
d7a89e5 to
43f5073
Compare
|
Follow-up: removed |
|
Merged! 🎉 Thanks, @glenn-jocher, for tightening up the docs link-checking workflow and making spellcheck far more reliable. As Benjamin Franklin said, “An ounce of prevention is worth a pound of cure.” This update is a perfect example of that: reducing false positives, normalizing generated HTML text, and expanding valid ignores helps CI focus on real issues instead of noise. Really appreciate the thoughtful polish here — improvements like this make reviews smoother and the |
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
🧹 This PR improves the docs link-checking workflow by making spellcheck more reliable and reducing false positives from generated HTML content.
📊 Key Changes
.github/workflows/links.ymlto replace curly apostrophes with standard apostrophes before runningcodespell.<script>,<style>, and avatar fallback HTML, while extending it to better normalize page text for spellchecking.codespellignore list with additional valid words and proper names, includingVektor,MITRE, andConfidencial.🎯 Purpose & Impact
ultralytics/docsrepository.