Protect ROADMAP helper missing-path behavior#3117
Open
Yeachan-Heo wants to merge 1 commit into
Open
Conversation
Add the missing explicit-path regression so operators keep the current fail-fast contract covered, and record the completed ROADMAP follow-up. Constraint: scope limited to ROADMAP helper regression coverage plus the DONE roadmap entry; tests/__init__.py is included so the requested python -m unittest tests.test_roadmap_helpers invocation resolves locally instead of an external tests package. Rejected: changing roadmap-next-id.sh behavior | dogfood showed the script already returns the desired nonzero empty-stdout error. Confidence: high Scope-risk: narrow Directive: Keep stdout reserved for the single next id on successful roadmap-next-id.sh runs. Tested: python -m unittest tests.test_roadmap_helpers -q; scripts/roadmap-check-ids.sh ROADMAP.md; scripts/roadmap-next-id.sh ROADMAP.md; git diff --check -- ROADMAP.md tests/test_roadmap_helpers.py tests/__init__.py
Contributor
Author
|
MERGE_READY — OWNER_CONFIRMATION_REQUIRED Plain review checklist:
I am not merging because this PR targets — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python -m unittest tests.test_roadmap_helpers -qresolves this repo's tests packageVerification
python -m unittest tests.test_roadmap_helpers -qscripts/roadmap-check-ids.sh ROADMAP.mdscripts/roadmap-next-id.sh ROADMAP.mdgit diff --check -- ROADMAP.md tests/test_roadmap_helpers.py tests/__init__.py