fix: ConPTY stdio leak, profile font CSS, xterm cell seams#16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dotnet run, bash background tasks), ConPTY children were inheriting those handles and writing to the launching shell instead of the PTY pipe — leaving xterm with no output and broken input.0xProto Nerd Font. xterm.js drops the value straight into CSSfont-family, where unquoted names with spaces fail to resolve. Quote the value (and append, monospace) both at import time and when applying overrides, so existing saved sessions render correctly without re-import.customGlyphsso box-drawing/block characters render with built-in glyphs that tile flush across cells.Testing
dotnet run(or any console parent). Create a session — terminal should print and accept input.tree,claude's welcome card). Confirm no thin seams between adjacent solid blocks.state.json(with unquotedProfileFontFamily) should pick up the correct font without manual re-import.Developer notes
FreeConsole+SetStdHandle(..., IntPtr.Zero).FreeConsolealone isn't enough — when the parent hands us pipe handles (not a console), only clearing the std handle slots prevents inheritance.customGlyphsonly covers the box-drawing/block Unicode ranges. Nerd Font Private Use Area glyphs still seam in the DOM renderer; the proper fix for those is a canvas/webgl renderer addon, which would require pulling in a new asset. Not done here.WindowsTerminalProfileService.QuoteFontFace) and at apply time (TerminalBridge.QuoteFontFamily) so saved sessions don't need to be re-imported to benefit.