Ship terminal-init.js + transparent HTML in MSI; guard Assets drift in CI#21
Merged
Conversation
… drift The MSI shipped only terminal.html / xterm.js / xterm.css / xterm-addon-fit.js even though terminal.html has loaded terminal-init.js since commit 75280b1 and transparent sessions load terminal-transparent.html. Installed users therefore got a blank terminal pane — portable ZIP users were unaffected because the ZIP mirrors the whole publish output. - WiX now lists terminal-init.js and terminal-transparent.html as components. - A new CI step diffs src/CodeShellManager/Assets/ against the <File Source> refs in the WiX manifest and fails the build if they drift, so adding a new Asset file without updating WiX can't slip through again. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
terminal.html<script src=\"terminal-init.js\">since 75280b1, plus transparent sessions loadterminal-transparent.html, but neither file was in the WiX manifest. Installed users got a blank terminal pane; portable ZIP users were unaffected.installer/CodeShellManager.wxs.src/CodeShellManager/Assets/against the<File Source=\"\$(var.PublishDir)\Assets\...\">refs in the WiX manifest and fails the build if they drift.Test plan
🤖 Generated with Claude Code