Anchors in TinyMCE-links does not allow curly brace

[enkelmedia]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.0.3 (but also all other versions back to v8 at least)

Bug summary

I've found a quite rare issue but I wanted to post it and offer a solution.

When using the link picker inside TinyMCE to pick content or media and also adding a query string that contains a } the dialog blows up when editing the link.

This is because the code that extracts the UDI inside tinymce.service.js assumes that the last } is the closing curly brace of the UDI (if any).

The issue can be seen here:
https://github.com/umbraco/Umbraco-CMS/blob/422218ea1599e961385eca4ec92a5cafb8fbe5f2/src/Umbraco.Web.UI.Client/src/common/services/tinymce.service.js#L1187C121-L1187C121

I'm thinking that we have a couple of options here:

• Introduce a "helper" that would take in any URL and successfully extract a UDI from it (if any)
• At lest update the code so that it discards the query string when trying to figure out the UDI.

Specifics

No response

Steps to reproduce

• Create a RTE
• Write text, select and click "Link"-button
• Pick a content node in the tree
• Enter anything that contains a } into the anchor-textbox.

Expected result / actual result

Parser should only look at the UDI and allow } to be a part of the URL.

[github-actions]

Hi there @enkelmedia!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[andr317c]

Hey!
Thanks for reporting this issue, and also creating a PR for it 💪 I was able to reproduce this on v13.0.3 and 12.3.6