Adjust example for overlay in umb-child-selector #8045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey Bjarne, You've been busy! Thanks for this work. We'll check it out and shout if we have questions. Emma |
# Conflicts: # src/Umbraco.Web.UI.Client/src/views/documenttypes/views/permissions/permissions.controller.js
Member
|
Wonderful, works like a charm! Thanks @bjarnef! 👍 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR shouldn't break anything. The
umb-child-selectorcomponent is used two places in core: document type and media type permission views.These already used
overlayService. I have adjusted these a bit and updated the example the useoverlayServiceinstead sinceumb-overlayis legacy and might be removed in a future version of Umbraco.If developers are using this in packages and have added
umb-overlayto their views and implemented show/hide of this overlay in theaddfunction in the controller, this would still work.It is however recommended to use
overlayServicenow, so I have therefore updated the example shown in the directive.