Data type API helper: Update default maxChars in createTextstringDataType
#328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change default maxChars value from 0 to 50 in createTextstringDataType method.
andr317c
deleted the
v17/qa/set-valid-default-for-text-string-data-type-max-chars
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I've changed the default
maxCharsvalue from 0 to 50 in thecreateTextstringDataTypemethod. With umbraco/Umbraco-CMS#20843 the value of zero will be considered invalid, and so this causes failing tests.It has previously been considered to have the meaning of being "unlimited", but for a text string that is limited by the size of the database field used for storing it, a value of unlimited doesn't make sense.