Skip to content

V17 updated tab name to match frontend changes #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2025
Merged

V17 updated tab name to match frontend changes #333

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cfb124
Updated helper
andr317c Nov 19, 2025
155fa3e
Merge branch 'refs/heads/v17/dev' into v17/update/tab-name
andr317c Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/helpers/UiBaseLocators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,10 @@ export class UiBaseLocators {
await this.page.waitForTimeout(400);
await this.unnamedTabTxt.clear();
await this.unnamedTabTxt.fill(tabName);
await expect(this.page.getByTestId('tab:' + tabName)).toBeVisible();
// We use this to make sure the test id is updated
await this.page.getByRole('tab', { name: 'Design' }).click();
// We click again to make sure the tab is focused
await this.page.getByTestId('tab:' + tabName).click();
}

async searchForTypeToFilterValue(searchValue: string) {
Expand Down