Skip to content

Menu-Item: Remove z-index stacking #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2025
Merged

Menu-Item: Remove z-index stacking #1192

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c83388
Remove the z-index inside teh button in the menu-item
engijlr Oct 3, 2025
da99d41
implement hover states
nielslyngsoe Oct 3, 2025
0a626ae
Merge branch 'main' into v1/bugfix/menu-item-z-index
nielslyngsoe Oct 6, 2025
0191a4c
ensure there is a origin for the :has selector
nielslyngsoe Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 16 additions & 24 deletions packages/uui-menu-item/lib/uui-menu-item.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
render() {
return html`
<div id="menu-item" aria-label="menuitem" role="menuitem">
<div id="label-button-background"></div>
${this.hasChildren
? html`<button
id="caret-button"
Expand All @@ -231,7 +232,6 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
? this._renderLabelAsAnchor()
: this._renderLabelAsButton()}

<div id="label-button-background"></div>
<slot id="actions-container" name="actions"></slot>
${this.loading
? html`<uui-loader-bar id="loader"></uui-loader-bar>`
Expand Down Expand Up @@ -266,12 +266,8 @@ export class UUIMenuItemElement extends SelectOnlyMixin(

/** Not active, not selected, not disabled: */
:host(:not([active], [selected], [disabled], [select-mode='highlight']))
#menu-item
#label-button:hover
~ #label-button-background,
:host(:not([active], [selected], [disabled]))
#menu-item
#caret-button:hover {
#menu-item:has(#label-button:hover)
#label-button-background {
background-color: var(
--uui-menu-item-background-color-hover,
var(--uui-color-surface-emphasis)
Expand Down Expand Up @@ -301,7 +297,9 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
var(--uui-color-current)
);
}
:host([active]) #label-button:hover ~ #label-button-background,
:host([active])
#menu-item:has(#label-button:hover)
#label-button-background,
:host([active]) #caret-button:hover {
background-color: var(
--uui-menu-item-background-color-active-hover,
Expand Down Expand Up @@ -336,8 +334,8 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
}
/** Selected, not highlight mode */
:host([selected]:not([select-mode='highlight'], [disabled]))
#label-button:hover
~ #label-button-background,
#menu-item:has(#label-button:hover)
#label-button-background,
:host([selected]:not([select-mode='highlight'], [disabled]))
#caret-button:hover {
background-color: var(
Expand All @@ -348,9 +346,8 @@ export class UUIMenuItemElement extends SelectOnlyMixin(

/** highlight mode, default */
:host([select-mode='highlight']:not([disabled], [active], [selectable]))
#menu-item
#label-button:hover
~ #label-button-background {
#menu-item:has(#label-button:hover)
#label-button-background {
border-radius: var(--uui-border-radius);
background-color: var(
--uui-menu-item-background-color-highlight,
Expand All @@ -367,9 +364,8 @@ export class UUIMenuItemElement extends SelectOnlyMixin(

/** highlight mode, active & selected */
:host([select-mode='highlight'][active][selected]:not([disabled]))
#menu-item
#label-button:hover
~ #label-button-background {
#menu-item:has(#label-button:hover)
#label-button-background {
border-radius: var(--uui-border-radius);
background-color: var(
--uui-menu-item-background-color-highlight-active-selected,
Expand Down Expand Up @@ -447,15 +443,13 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
}

:host([select-mode='highlight'][selectable]:not([disabled]))
#menu-item
#label-button:hover
~ #label-button-background::after {
#menu-item:has(#label-button:hover)
#label-button-background::after {
opacity: 0.33;
}
:host([select-mode='highlight'][selected]:not([disabled]))
#menu-item
#label-button:hover
~ #label-button-background::after {
#menu-item:has(#label-button:hover)
#label-button-background::after {
opacity: 0.66;
}

Expand All @@ -480,7 +474,6 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
background-color: transparent;
cursor: pointer;
min-height: var(--uui-size-12);
z-index: 1;
}

#label-button {
Expand All @@ -498,7 +491,6 @@ export class UUIMenuItemElement extends SelectOnlyMixin(
text-decoration: none;
color: currentColor;
min-height: var(--uui-size-12);
z-index: 1;
font-weight: inherit;
}

Expand Down
Loading